Skip to content

feat: allow epoch 3.3.0 in node config #6584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat: allow epoch 3.3.0 in node config #6584

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions stackslib/src/config/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,6 +720,8 @@ impl Config {
Ok(StacksEpochId::Epoch31)
} else if epoch_name == EPOCH_CONFIG_3_2_0 {
Ok(StacksEpochId::Epoch32)
} else if epoch_name == EPOCH_CONFIG_3_3_0 {
Ok(StacksEpochId::Epoch33)
} else {
Err(format!("Unknown epoch name specified: {epoch_name}"))
}?;
Expand Down Expand Up @@ -748,6 +750,8 @@ impl Config {
StacksEpochId::Epoch30,
StacksEpochId::Epoch31,
StacksEpochId::Epoch32,
// todo: when epoch 3.3 becomes mandatory
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you create an issue for that TODO and tag it with 3.3.0.0.0 so we don't forget it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created here: #6588

But I'm not allowed to set tags

// StacksEpochId::Epoch33,
];
for (expected_epoch, configured_epoch) in expected_list
.iter()
Expand Down Expand Up @@ -1708,6 +1712,7 @@ pub const EPOCH_CONFIG_2_5_0: &str = "2.5";
pub const EPOCH_CONFIG_3_0_0: &str = "3.0";
pub const EPOCH_CONFIG_3_1_0: &str = "3.1";
pub const EPOCH_CONFIG_3_2_0: &str = "3.2";
pub const EPOCH_CONFIG_3_3_0: &str = "3.3";

#[derive(Clone, Deserialize, Default, Debug)]
#[serde(deny_unknown_fields)]
Expand Down
Loading