Signers should not issue rejections if a block has already reached consensus during validation #6826
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was seeing the mock GSM signer issuing rejections in an unexpected case (seems to be the case in non GSM signer case as well). Essentially was seeing the singer block reject a block with "Miner's block proposal does not confirm as many blocks as we expect" and it is because in the validate path it wasn't actually checking if the block it was examining had reached consensus in between the validation submission and the validation response. It correctly checks the consensus case in the signature path just not the validation path. This should get rid of these red herring rejections. Still adding a test.