Skip to content

Signers should not issue rejections if a block has already reached consensus during validation #6826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jacinta-stacks wants to merge 1 commit into
base: develop
Choose a base branch
from
+4 −6
Open

Signers should not issue rejections if a block has already reached consensus during validation #6826

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions stacks-signer/src/v0/signer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1399,7 +1399,7 @@ impl Signer {
debug!("{self}: Received a block validate response for a block we have not seen before. Ignoring...");
return;
};
if block_info.is_locally_finalized() {
if block_info.is_locally_finalized() || block_info.has_reached_consensus() {
debug!("{self}: Received block validation for a block that is already marked as {}. Ignoring...", block_info.state);
return;
}
Expand Down Expand Up @@ -1464,15 +1464,13 @@ impl Signer {
debug!("{self}: Received a block validate response for a block we have not seen before. Ignoring...");
return;
};
if block_info.is_locally_finalized() {
if block_info.is_locally_finalized() || block_info.has_reached_consensus() {
debug!("{self}: Received block validation for a block that is already marked as {}. Ignoring...", block_info.state);
return;
}
if let Err(e) = block_info.mark_locally_rejected() {
if !block_info.has_reached_consensus() {
warn!("{self}: Failed to mark block as locally rejected: {e:?}",);
return;
}
warn!("{self}: Failed to mark block as locally rejected: {e:?}",);
return;
}
let block_rejection = BlockRejection::from_validate_rejection(
block_validate_reject.clone(),
Expand Down
Loading