aac: runtime check error to expect acceptable

[federico-stacks]

Description

This PR converts all RuntimeCheckErrorKind variants marked as functionally unreachable in runtime_analysis_tests.rs to ExpectsAcceptable, with the following exceptions:

• ExecutionTimeExpired is kept as-is to maintain alignment with the CostErrors variants.
• SupertypeTooLarge is converted to ExpectsRejectable to preserve the logic in RuntimeCheckErrorKind::rejectable().

NOTE: There are 56 affected variants. To simplify the review process, each variant conversion has been split into its own commit.

Applicable issues

• fixes aac: convert unreachable RuntimeCheckErrorKind variants to ExpectsAcceptable #6876

Additional info (benefits, drawbacks, caveats)

Checklist

• Test coverage for new or modified code paths
• For new Clarity features or consensus changes, add property tests (see docs/property-testing.md)
• Changelog is updated
• Required documentation changes (e.g., rpc/openapi.yaml for RPC endpoints, event-dispatcher.md for new events)
• New clarity functions have corresponding PR in clarity-benchmarking repo

[brice-stacks]

Thanks! LGMT 😄

[francesco-stacks]

lgtm! Just before approving, I was wondering if we already thought about a mechanism we should have in place to immediately find out if an ExpectAcceptable error is ever committed to the chain. Should we discuss this with the devops team?

[federico-stacks]

lgtm! Just before approving, I was wondering if we already thought about a mechanism we should have in place to immediately find out if an ExpectAcceptable error is ever committed to the chain. Should we discuss this with the devops team?

there is a discussion about this here: https://github.com/stx-labs/core-epics/issues/119 (that also mention the monitoring)

TLDR: these ExpectAcceptable are just here for convenience and will be converted to Unreachable before the fork.

[francesco-stacks]

Lgtm!