Merged
Conversation
Move capability discovery from Client to StdioSession to break the circular dependency where session.GetClient().AddToMCPServerWithSession(session) was called. This cleaner design separates concerns and makes the code more maintainable.
Add configurable session timeouts to replace hardcoded values. The config now supports 'sessions.timeout' and 'sessions.cleanupInterval' using Go duration format (e.g., '5m', '30s'). Custom JSON unmarshaling ensures only duration strings are accepted, not numeric values.
Update inline package to properly handle time.Duration timeouts after the config changes. Remove unused time import and fix test cases to use duration strings instead of numeric values.
- Remove incorrect guideline about extracting interfaces to internal/interfaces - Update Makefile for better formatting - Fix documentation examples to use correct syntax - Update integration test config
Allows configuring session timeout, cleanup interval, and max sessions per user through the config file instead of hardcoded values.
Changed tokenStore from UserTokenStore to Storage interface to avoid runtime type assertions. This makes the code cleaner and type-safe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed circular dependencies, made session timeouts configurable, added trace logging for debugging, and eliminated runtime type assertions.