Update release CI to use trusted publishing #818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serban-nicusor-toptal
approved these changes
Oct 17, 2025
Contributor
serban-nicusor-toptal
left a comment
serban-nicusor-toptal
left a comment
There was a problem hiding this comment.
LGTM. Thanks!
I have just one question because I am unsure, looking at their docs, in the example they specify a url, is that needed or it's optional? ( their docs don't really say it )
# .github/workflows/ci-cd.yml
jobs:
pypi-publish:
name: Upload release to PyPI
runs-on: ubuntu-latest
environment:
name: pypi
url: https://pypi.org/p/<your-pypi-project-name> <--- this one here
...
Member
Author
|
I don’t think that’s required, I just took it from the config I use at https://github.com/roualdes/bridgestan/blob/2f2d56bd5488b3f8a99aeacf7fb349e12a36328c/.github/workflows/release.yaml#L116, which I know works |
Contributor
|
Awesome! I just wanted to double-check. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #817