feat: Select token supports uppercase search & Support symbol search#325
Open
nlyrthiia wants to merge 3 commits intostarknet-io:devfrom
Open
feat: Select token supports uppercase search & Support symbol search#325nlyrthiia wants to merge 3 commits intostarknet-io:devfrom
nlyrthiia wants to merge 3 commits intostarknet-io:devfrom
Conversation
dan-ziv
suggested changes
Nov 27, 2022
| const results = tokens.filter(token => token.name.toLowerCase().includes(searchTerm)); | ||
| const results = tokens.filter(token => { | ||
| const {name, symbol} = token; | ||
| const searchTermValue = searchTerm.toLowerCase(); |
There was a problem hiding this comment.
I guess we can move this line outside of the filter iterator?
|
Hey @nlyrthiia, thanks for this PR - good idea :-) |
Author
|
@dan-ziv ok gratitude for the suggestion, the code has been modified |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Changes
When entering 'ETH', 'usdc' in the search box, the correct results cannot be obtained. After the modification, the uppercase can also be used to search for the correct results and the search for the symbol field has been increased. There is also a discussion about whether spaces should be included in the search. Referring to uniswap, both upper and lower case can be searched normally, spaces are not in the search field, and only symbols are retrieved.
change:
Screencast.from.27-11-22.09.37.54.webm
origin:
Screencast.from.27-11-22.09.35.47.webm
uniswap:
Screencast.from.27-11-22.09.38.21.webm
Checklist
<type>[optional scope]: <description>, e.g:fix: prevent racing of requestsThis change is