Skip to content

feat: Select token supports uppercase search & Support symbol search #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nlyrthiia wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

feat: Select token supports uppercase search & Support symbol search #325

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
83e4338
feat: select_token_supports_uppercase_search
nlyrthiia Nov 27, 2022
3aa6581
Merge branch 'dev' into select_token_supports_uppercase_search
Nov 27, 2022
c5af904
fix: optimize iterator code
nlyrthiia Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/components/UI/SearchToken/SearchToken.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,15 @@ export const SearchToken = ({tokens, onSearchResults}) => {
};

useEffect(() => {
const results = tokens.filter(token => token.name.toLowerCase().includes(searchTerm));
const results = tokens.filter(token => {
const {name, symbol} = token;
const searchTermValue = searchTerm.toLowerCase();
Copy link

@dan-ziv dan-ziv Nov 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can move this line outside of the filter iterator?


return (
name.toLowerCase().includes(searchTermValue) ||
symbol.toLowerCase().includes(searchTermValue)
);
});
onSearchResults(results);
}, [searchTerm]);

Expand Down