starknet_os_flow_tests: migrate test_compiled_class_hash_migration#10210
Closed
Conversation
|
This change is |
|
Artifacts upload workflows: |
dorimedini-starkware
requested review from
AvivYossef-starkware,
Yoni-Starkware and
meship-starkware
This was referenced Nov 17, 2025
This was referenced Nov 17, 2025
This was referenced Nov 17, 2025
Collaborator
Author
meship-starkware
requested changes
Nov 18, 2025
Collaborator
meship-starkware
left a comment
meship-starkware
left a comment
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @Yoni-Starkware)
crates/starknet_os_flow_tests/src/tests.rs line 2947 at r1 (raw file):
); // Migration is enabled, and V1-declare should be enabled only for the first block. block_ctx.versioned_constants.enable_casm_hash_migration = true;
This should also be false for the first block. We do not support migrating declared transactions, but we also don't want the first declaration to migrate, as we want to test the migration of the class after it was previously declared.
Suggestion:
block_ctx.versioned_constants.enable_casm_hash_migration = *i > 0;
dorimedini-starkware
force-pushed
the
10-11-starknet_os_flow_tests_add_all_uncovered_regression_test
branch
from
ded6eb6 to
2ab1b55
Compare
dorimedini-starkware
force-pushed
the
11-17-starknet_os_flow_tests_migrate_test_compiled_class_hash_migration
branch
from
ea95b46 to
057d535
Compare
dorimedini-starkware
changed the base branch from
10-11-starknet_os_flow_tests_add_all_uncovered_regression_test
to
11-18-starknet_os_flow_tests_better_v1-v2_class_handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.