-
Notifications
You must be signed in to change notification settings - Fork 65
blockifier_test_utils: update test contract for revert test with meta tx #9546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blockifier_test_utils: update test contract for revert test with meta tx #9546
Conversation
ef2daeb to
bde079d
Compare
9ab8181 to
fb69c27
Compare
bde079d to
a027abf
Compare
fb69c27 to
972bd32
Compare
a027abf to
d561db2
Compare
972bd32 to
2f87b6b
Compare
d561db2 to
972ecdc
Compare
rotem-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rotem-starkware reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @AvivYossef-starkware, @meship-starkware, and @Yoni-Starkware)
crates/blockifier/src/execution/syscalls/syscall_tests/call_contract.rs line 45 at r1 (raw file):
to_panic, is_meta_tx ];
Non-blocking
Suggestion:
let inner_calldata_args = &[new_class_hash.0, to_panic];
let calldata = calldata_macro![
**test_contract.get_instance_address(0),
selector_from_name("test_revert_helper").0,
inner_calldata_args.len().into(),
inner_calldata_args.into(),
is_meta_tx
];
crates/blockifier/src/execution/syscalls/syscall_tests/call_contract.rs line 117 at r1 (raw file):
] .concat(), ));
Non-blocking
Suggestion:
let calldata = calldata_macro![
**test_contract.get_instance_address(0),
selector_from_name("middle_revert_contract").0,
middle_call_data.0.len().into(),
middle_call_data.0.to_vec(),
is_meta_tx
];2f87b6b to
c95f212
Compare
972ecdc to
b41d51a
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 7 of 9 files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, @rotem-starkware, and @Yoni-Starkware)
crates/blockifier/src/execution/syscalls/syscall_tests/call_contract.rs line 117 at r1 (raw file):
Previously, rotem-starkware wrote…
Non-blocking
done. note that here and above, the calldata macro cannot accept a mix of felts and vec[felt]s, so the concat is required; and the macro cannot accept a vector at all, so I now use the new Calldata::from
rotem-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rotem-starkware reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @Yoni-Starkware)
c95f212 to
e4fd9ba
Compare
200080b to
83b24d4
Compare
rotem-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rotem-starkware reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @Yoni-Starkware)
e4fd9ba to
6eae2f2
Compare
83b24d4 to
ae79a28
Compare
6eae2f2 to
fb58ec6
Compare
ae79a28 to
1c7ed1b
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dorimedini-starkware reviewed 1 of 1 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @Yoni-Starkware)
c60caa8

No description provided.