Skip to content

Conversation

@dorimedini-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

dorimedini-starkware commented Oct 11, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-blockifier_test_utils_update_test_contract_for_revert_test_with_meta_tx branch from ef2daeb to bde079d Compare November 20, 2025 10:48
@dorimedini-starkware dorimedini-starkware force-pushed the 10-09-starknet_os_flow_tests_migrate_test_initial_sierra_gas branch from 9ab8181 to fb69c27 Compare November 20, 2025 12:03
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-blockifier_test_utils_update_test_contract_for_revert_test_with_meta_tx branch from bde079d to a027abf Compare November 20, 2025 12:03
@dorimedini-starkware dorimedini-starkware force-pushed the 10-09-starknet_os_flow_tests_migrate_test_initial_sierra_gas branch from fb69c27 to 972bd32 Compare November 25, 2025 15:55
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-blockifier_test_utils_update_test_contract_for_revert_test_with_meta_tx branch from a027abf to d561db2 Compare November 25, 2025 15:55
@dorimedini-starkware dorimedini-starkware force-pushed the 10-09-starknet_os_flow_tests_migrate_test_initial_sierra_gas branch from 972bd32 to 2f87b6b Compare November 26, 2025 19:34
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-blockifier_test_utils_update_test_contract_for_revert_test_with_meta_tx branch from d561db2 to 972ecdc Compare November 26, 2025 19:34
Copy link
Contributor

@rotem-starkware rotem-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rotem-starkware reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @AvivYossef-starkware, @meship-starkware, and @Yoni-Starkware)


crates/blockifier/src/execution/syscalls/syscall_tests/call_contract.rs line 45 at r1 (raw file):

        to_panic,
        is_meta_tx
    ];

Non-blocking

Suggestion:

    let inner_calldata_args = &[new_class_hash.0, to_panic];
    let calldata = calldata_macro![
        **test_contract.get_instance_address(0),
        selector_from_name("test_revert_helper").0,
        inner_calldata_args.len().into(),
        inner_calldata_args.into(),
        is_meta_tx
    ];

      

crates/blockifier/src/execution/syscalls/syscall_tests/call_contract.rs line 117 at r1 (raw file):

        ]
        .concat(),
    ));

Non-blocking

Suggestion:

    let calldata = calldata_macro![
        **test_contract.get_instance_address(0),
        selector_from_name("middle_revert_contract").0,
        middle_call_data.0.len().into(),
        middle_call_data.0.to_vec(),
        is_meta_tx
    ];

@dorimedini-starkware dorimedini-starkware force-pushed the 10-09-starknet_os_flow_tests_migrate_test_initial_sierra_gas branch from 2f87b6b to c95f212 Compare November 27, 2025 11:29
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-blockifier_test_utils_update_test_contract_for_revert_test_with_meta_tx branch from 972ecdc to b41d51a Compare November 27, 2025 11:29
Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 7 of 9 files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, @rotem-starkware, and @Yoni-Starkware)


crates/blockifier/src/execution/syscalls/syscall_tests/call_contract.rs line 117 at r1 (raw file):

Previously, rotem-starkware wrote…

Non-blocking

done. note that here and above, the calldata macro cannot accept a mix of felts and vec[felt]s, so the concat is required; and the macro cannot accept a vector at all, so I now use the new Calldata::from

Copy link
Contributor

@rotem-starkware rotem-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@rotem-starkware reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @Yoni-Starkware)

@dorimedini-starkware dorimedini-starkware force-pushed the 10-09-starknet_os_flow_tests_migrate_test_initial_sierra_gas branch from c95f212 to e4fd9ba Compare November 27, 2025 13:35
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-blockifier_test_utils_update_test_contract_for_revert_test_with_meta_tx branch 2 times, most recently from 200080b to 83b24d4 Compare November 27, 2025 13:59
Copy link
Contributor

@rotem-starkware rotem-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rotem-starkware reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @Yoni-Starkware)

@dorimedini-starkware dorimedini-starkware force-pushed the 10-09-starknet_os_flow_tests_migrate_test_initial_sierra_gas branch from e4fd9ba to 6eae2f2 Compare December 2, 2025 10:57
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-blockifier_test_utils_update_test_contract_for_revert_test_with_meta_tx branch from 83b24d4 to ae79a28 Compare December 2, 2025 10:57
@dorimedini-starkware dorimedini-starkware force-pushed the 10-09-starknet_os_flow_tests_migrate_test_initial_sierra_gas branch from 6eae2f2 to fb58ec6 Compare December 2, 2025 11:56
@dorimedini-starkware dorimedini-starkware force-pushed the 10-10-blockifier_test_utils_update_test_contract_for_revert_test_with_meta_tx branch from ae79a28 to 1c7ed1b Compare December 2, 2025 11:56
@dorimedini-starkware dorimedini-starkware changed the base branch from 10-09-starknet_os_flow_tests_migrate_test_initial_sierra_gas to main-v0.14.1-committer December 2, 2025 12:07
Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @Yoni-Starkware)

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue Dec 2, 2025
Merged via the queue into main-v0.14.1-committer with commit c60caa8 Dec 2, 2025
43 of 46 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants