Skip to content

blockifier: update test contract for test_new_contract_flow #9514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dorimedini-starkware merged 1 commit into from
Oct 28, 2025
Merged

blockifier: update test contract for test_new_contract_flow #9514

dorimedini-starkware merged 1 commit into from
Oct 28, 2025

Conversation

@dorimedini-starkware
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware commented Oct 6, 2025

No description provided.

@reviewable-StarkWare
Copy link

reviewable-StarkWare commented Oct 6, 2025

This change is Reviewable

This was referenced Oct 6, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@dorimedini-starkware Graphite App
Copy link
Collaborator Author

dorimedini-starkware commented Oct 6, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Oct 6, 2025
Closed
Merged
Merged
Merged
Merged
Merged
@github-actions
Copy link

github-actions bot commented Oct 6, 2025 •
edited
Loading

Artifacts upload workflows:

@dorimedini-starkware dorimedini-starkware self-assigned this Oct 6, 2025
@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review October 6, 2025 17:25
@dorimedini-starkware dorimedini-starkware force-pushed the 10-05-blockifier_update_test_contract_for_test_new_contract_flow branch from 3777522 to b404c7a Compare October 19, 2025 18:43
meship-starkware
meship-starkware reviewed Oct 23, 2025
View reviewed changes
Copy link
Collaborator

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meship-starkware reviewed 1 of 8 files at r1, 10 of 10 files at r5, all commit messages.
Reviewable status: 11 of 12 files reviewed, all discussions resolved (waiting on @alonh5, @AvivYossef-starkware, and @Yoni-Starkware)

@dorimedini-starkware dorimedini-starkware force-pushed the 10-03-starknet_os_flow_tests_migrate_test_v1_bound_accounts_cairo1 branch from 3e640a9 to d758748 Compare October 23, 2025 08:49
@dorimedini-starkware dorimedini-starkware force-pushed the 10-05-blockifier_update_test_contract_for_test_new_contract_flow branch from b404c7a to 71d1a40 Compare October 23, 2025 08:49
meship-starkware
meship-starkware reviewed Oct 23, 2025
View reviewed changes
Copy link
Collaborator

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meship-starkware reviewed 2 of 2 files at r6, all commit messages.
Reviewable status: 11 of 12 files reviewed, all discussions resolved (waiting on @alonh5, @AvivYossef-starkware, and @Yoni-Starkware)

@dorimedini-starkware dorimedini-starkware force-pushed the 10-03-starknet_os_flow_tests_migrate_test_v1_bound_accounts_cairo1 branch 2 times, most recently from 396441e to a71da38 Compare October 23, 2025 11:12
@dorimedini-starkware dorimedini-starkware force-pushed the 10-05-blockifier_update_test_contract_for_test_new_contract_flow branch from 71d1a40 to 39a4c59 Compare October 23, 2025 11:12
dorimedini-starkware
dorimedini-starkware commented Oct 23, 2025
View reviewed changes
Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 of 2 files at r6, all commit messages.
Reviewable status: 11 of 12 files reviewed, all discussions resolved (waiting on @alonh5, @AvivYossef-starkware, and @Yoni-Starkware)

@graphite-app graphite-app bot changed the base branch from 10-03-starknet_os_flow_tests_migrate_test_v1_bound_accounts_cairo1 to graphite-base/9514 October 23, 2025 12:27
@dorimedini-starkware dorimedini-starkware force-pushed the 10-05-blockifier_update_test_contract_for_test_new_contract_flow branch from 39a4c59 to e28090b Compare October 23, 2025 12:44
@dorimedini-starkware dorimedini-starkware changed the base branch from graphite-base/9514 to main October 23, 2025 12:44
meship-starkware
meship-starkware approved these changes Oct 26, 2025
View reviewed changes
Copy link
Collaborator

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meship-starkware reviewed 1 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @alonh5, @AvivYossef-starkware, and @Yoni-Starkware)

dorimedini-starkware
dorimedini-starkware commented Oct 26, 2025
View reviewed changes
Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 of 8 files at r1, 8 of 10 files at r5, 1 of 2 files at r6, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @alonh5, @AvivYossef-starkware, and @Yoni-Starkware)

@dorimedini-starkware dorimedini-starkware force-pushed the 10-05-blockifier_update_test_contract_for_test_new_contract_flow branch from e28090b to da2556c Compare October 26, 2025 08:26
@dorimedini-starkware dorimedini-starkware force-pushed the 10-05-blockifier_update_test_contract_for_test_new_contract_flow branch from da2556c to e219708 Compare October 28, 2025 08:51
@dorimedini-starkware dorimedini-starkware changed the base branch from main to main-v0.14.1-committer October 28, 2025 08:51
@dorimedini-starkware dorimedini-starkware mentioned this pull request Oct 28, 2025
Merged
@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue Oct 28, 2025
Merged via the queue into main-v0.14.1-committer with commit a4b41f9 Oct 28, 2025
24 of 37 checks passed
This was referenced Oct 28, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@meship-starkware meship-starkware meship-starkware approved these changes

@AvivYossef-starkware AvivYossef-starkware Awaiting requested review from AvivYossef-starkware

@Yoni-Starkware Yoni-Starkware Awaiting requested review from Yoni-Starkware

@alonh5 alonh5 Awaiting requested review from alonh5

Assignees

@dorimedini-starkware dorimedini-starkware

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dorimedini-starkware @reviewable-StarkWare @meship-starkware