Skip to content

starknet_os_flow_tests: add V1-bound cairo0 account for flow tests #9490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dorimedini-starkware merged 2 commits into from
Oct 23, 2025
Merged

starknet_os_flow_tests: add V1-bound cairo0 account for flow tests #9490

dorimedini-starkware merged 2 commits into from
Oct 23, 2025

Conversation

@dorimedini-starkware
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware commented Oct 5, 2025

No description provided.

This was referenced Oct 5, 2025
Merged
Merged
Merged
Merged
@reviewable-StarkWare
Copy link

reviewable-StarkWare commented Oct 5, 2025

This change is Reviewable

This was referenced Oct 5, 2025
Merged
Merged
Merged
Merged
Merged
@github-actions
Copy link

github-actions bot commented Oct 5, 2025 •
edited
Loading

Artifacts upload workflows:

@dorimedini-starkware Graphite App
Copy link
Collaborator Author

dorimedini-starkware commented Oct 5, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Oct 5, 2025
Merged
Merged
Merged
Merged
Merged
Merged
@dorimedini-starkware dorimedini-starkware self-assigned this Oct 5, 2025
@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review October 5, 2025 07:47
@github-actions
Copy link

github-actions bot commented Oct 5, 2025 •
edited
Loading

Benchmark movements: tree_computation_flow performance improved 😺 tree_computation_flow time: [14.033 ms 14.198 ms 14.386 ms] change: [-5.7354% -3.7016% -1.6697%] (p = 0.00 < 0.05) Performance has improved. Found 3 outliers among 100 measurements (3.00%) 1 (1.00%) high mild 2 (2.00%) high severe full_committer_flow performance improved 😺 full_committer_flow time: [14.986 ms 15.142 ms 15.296 ms] change: [-3.9391% -2.7786% -1.6341%] (p = 0.00 < 0.05) Performance has improved. Found 13 outliers among 100 measurements (13.00%) 11 (11.00%) low mild 2 (2.00%) high mild

@dorimedini-starkware dorimedini-starkware force-pushed the 10-01-starknet_os_flow_tests_localize_expected_storage_updates_in_test_os_logic branch from c37d283 to f82250a Compare October 5, 2025 09:38
@dorimedini-starkware dorimedini-starkware force-pushed the 10-02-starknet_os_flow_tests_add_v1-bound_cairo0_account_for_flow_tests branch from b636de6 to 4c5ff1a Compare October 5, 2025 09:38
@dorimedini-starkware dorimedini-starkware mentioned this pull request Oct 5, 2025
Closed
@dorimedini-starkware dorimedini-starkware force-pushed the 10-01-starknet_os_flow_tests_localize_expected_storage_updates_in_test_os_logic branch from f82250a to 8373ec6 Compare October 6, 2025 16:51
@dorimedini-starkware dorimedini-starkware force-pushed the 10-02-starknet_os_flow_tests_add_v1-bound_cairo0_account_for_flow_tests branch from 4c5ff1a to 8ff5d45 Compare October 6, 2025 16:51
@dorimedini-starkware dorimedini-starkware mentioned this pull request Oct 6, 2025
Merged
This was referenced Oct 11, 2025
Merged
Merged
Merged
Merged
Merged
Closed
@dorimedini-starkware dorimedini-starkware force-pushed the 10-01-starknet_os_flow_tests_localize_expected_storage_updates_in_test_os_logic branch from 55c8825 to 93ca899 Compare October 14, 2025 10:21
@dorimedini-starkware dorimedini-starkware force-pushed the 10-02-starknet_os_flow_tests_add_v1-bound_cairo0_account_for_flow_tests branch from 6336f53 to 22f6f02 Compare October 14, 2025 10:21
This was referenced Oct 14, 2025
Merged
Merged
@dorimedini-starkware dorimedini-starkware force-pushed the 10-01-starknet_os_flow_tests_localize_expected_storage_updates_in_test_os_logic branch from 93ca899 to b5d5d74 Compare October 15, 2025 11:16
@dorimedini-starkware dorimedini-starkware force-pushed the 10-02-starknet_os_flow_tests_add_v1-bound_cairo0_account_for_flow_tests branch from 22f6f02 to a34a9e2 Compare October 15, 2025 11:17
@dorimedini-starkware dorimedini-starkware force-pushed the 10-01-starknet_os_flow_tests_localize_expected_storage_updates_in_test_os_logic branch from b5d5d74 to e619f3e Compare October 19, 2025 18:42
@dorimedini-starkware dorimedini-starkware force-pushed the 10-02-starknet_os_flow_tests_add_v1-bound_cairo0_account_for_flow_tests branch from a34a9e2 to 2e233a4 Compare October 19, 2025 18:42
@dorimedini-starkware dorimedini-starkware force-pushed the 10-01-starknet_os_flow_tests_localize_expected_storage_updates_in_test_os_logic branch from e619f3e to b252323 Compare October 22, 2025 10:23
@dorimedini-starkware dorimedini-starkware force-pushed the 10-02-starknet_os_flow_tests_add_v1-bound_cairo0_account_for_flow_tests branch from 2e233a4 to c6be946 Compare October 22, 2025 10:24
meship-starkware
meship-starkware approved these changes Oct 22, 2025
View reviewed changes
Copy link
Collaborator

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meship-starkware reviewed 4 of 6 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware and @Yoni-Starkware)

@dorimedini-starkware dorimedini-starkware force-pushed the 10-01-starknet_os_flow_tests_localize_expected_storage_updates_in_test_os_logic branch from b252323 to e874fe5 Compare October 22, 2025 15:02
@dorimedini-starkware dorimedini-starkware force-pushed the 10-02-starknet_os_flow_tests_add_v1-bound_cairo0_account_for_flow_tests branch from c6be946 to bc09d7f Compare October 22, 2025 15:02
@dorimedini-starkware dorimedini-starkware force-pushed the 10-01-starknet_os_flow_tests_localize_expected_storage_updates_in_test_os_logic branch from e874fe5 to 661ee19 Compare October 22, 2025 15:58
@dorimedini-starkware dorimedini-starkware force-pushed the 10-02-starknet_os_flow_tests_add_v1-bound_cairo0_account_for_flow_tests branch from bc09d7f to 003de2c Compare October 22, 2025 15:58
meship-starkware
meship-starkware approved these changes Oct 23, 2025
View reviewed changes
Copy link
Collaborator

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meship-starkware reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware and @Yoni-Starkware)

@dorimedini-starkware dorimedini-starkware changed the base branch from 10-01-starknet_os_flow_tests_localize_expected_storage_updates_in_test_os_logic to main October 23, 2025 09:11
dorimedini-starkware
dorimedini-starkware commented Oct 23, 2025
View reviewed changes
Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware and @Yoni-Starkware)

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue Oct 23, 2025
Merged via the queue into main with commit f46c2ab Oct 23, 2025
52 of 54 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@meship-starkware meship-starkware meship-starkware approved these changes

@AvivYossef-starkware AvivYossef-starkware Awaiting requested review from AvivYossef-starkware

@Yoni-Starkware Yoni-Starkware Awaiting requested review from Yoni-Starkware

Assignees

@dorimedini-starkware dorimedini-starkware

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dorimedini-starkware @reviewable-StarkWare @meship-starkware