starknet_os_flow_tests: move nonce manager into test manager

[dorimedini-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[dorimedini-starkware]

• starknet_os_flow_tests: migrate test_v1_bound_accounts_cairo1 #9496 : 2 dependent PRs (#9501 , #9514 )
• starknet_os_flow_tests: add V1-bound cairo1 account for flow tests #9495
• starknet_api: fix compiler->SNAPI contract class ABI string conversion for tests #9494
• starknet_os_flow_tests: migrate test_v1_bound_accounts_cairo0 #9493
• starknet_os_flow_tests: split get_class_info_of_cairo0_contract into function #9492
• starknet_os_flow_tests: more informative execution failure #9491
• starknet_os_flow_tests: add V1-bound cairo0 account for flow tests #9490
• starknet_os_flow_tests: localize expected storage updates in test_os_logic #9485
• starknet_os_flow_tests: migrate test_os_logic and some small refactors #9484
• blockifier_test_utils: add functionality to test contract for test_os_logic #9483
• blockifier_test_utils: add test_contract2 cairo0 contract #9482
• blockifier_test_utils: add delegate_proxy cairo0 contract #9481
• starknet_os_flow_tests: add control for expected reverting txs #9480
• starknet_os_flow_tests: migrate test_reverted_l1_handler_tx #9474
• starknet_os_flow_tests: reduce boilerplate with add_funded_account_invoke #9563
• starknet_os_flow_tests: move nonce manager into test manager #9562 👈 (View in Graphite)
• starknet_os_flow_tests: migrate test_reverted_invoke_tx #9473
• starknet_os_flow_tests: reduce boilerplate with perform_default_validations #9472
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[dorimedini-starkware]

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @nimrod-starkware)

---

a discussion (no related file):
reasons:

1. one less object to carry around
2. allows the next PR - reduce boilerplate with a utility method that invokes from the funded account with default resource bounds, while advancing the relevant nonce

[nimrod-starkware]

@nimrod-starkware reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @meship-starkware)

---

crates/starknet_os_flow_tests/src/test_manager.rs line 247 at r1 (raw file):

            per_block_transactions: vec![vec![]],
        }
    }

Suggestion:

    /// Creates a new `TestManager` with the provided initial state data and nonce manager.
    pub(crate) fn new_with_initial_state_data_and_nonce_manager(
        initial_state_data: InitialStateData<S>,
        nonce_manager: NonceManager,
    ) -> Self {
        Self {
            initial_state: initial_state_data.initial_state,
            execution_contracts: initial_state_data.execution_contracts,
            nonce_manager,
            per_block_transactions: vec![vec![]],
        }
    }

[dorimedini-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware, @meship-starkware, and @nimrod-starkware)

---

crates/starknet_os_flow_tests/src/test_manager.rs line 247 at r1 (raw file):

            per_block_transactions: vec![vec![]],
        }
    }

why? it's clear from the signature, and the current state of nonces is part of the initial state of the system

[dorimedini-starkware]

Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware, @meship-starkware, and @nimrod-starkware)

---

crates/starknet_os_flow_tests/src/test_manager.rs line 247 at r1 (raw file):

Previously, dorimedini-starkware wrote…

why? it's clear from the signature, and the current state of nonces is part of the initial state of the system

done

[nimrod-starkware]

@nimrod-starkware reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware and @meship-starkware)

[graphite-app]

Merge activity

• Oct 15, 10:42 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.