-
Notifications
You must be signed in to change notification settings - Fork 65
starknet_os_flow_tests: migrate test_initial_sierra_gas #9539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
starknet_os_flow_tests: migrate test_initial_sierra_gas #9539
Conversation
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @Yoni-Starkware)
crates/starknet_os_flow_tests/src/tests.rs line 2231 at r1 (raw file):
// L1 handler bounds test. let expected_l1_handler_gas_upper_bound = os_constants.l1_handler_max_amount_bounds.l2_gas.0; let expected_l1_handler_gas_lower_bound = expected_l1_handler_gas_upper_bound - 10001;
the original test subtracts exactly 10K, but it fails here, as the get_available_gas returns exactly 99990000, any ideas why? @meship-starkware
Code quote:
expected_l1_handler_gas_upper_bound - 10001;8a1fdf8 to
2787132
Compare
01b2f9d to
c3db116
Compare
2787132 to
492b9c7
Compare
c3db116 to
3ed646c
Compare
492b9c7 to
6a5be89
Compare
3ed646c to
57c0e9e
Compare
6a5be89 to
3050ce8
Compare
57c0e9e to
cc9b30a
Compare
3050ce8 to
d26bb4a
Compare
cc9b30a to
8a6fcbe
Compare
d26bb4a to
d0d082f
Compare
a20b5be to
2913251
Compare
2ff59a1 to
4cc533d
Compare
2913251 to
b36f6cd
Compare
4cc533d to
e868501
Compare
b36f6cd to
c4b1129
Compare
e868501 to
9ab8181
Compare
c4b1129 to
20e96e6
Compare
9ab8181 to
fb69c27
Compare
20e96e6 to
ac72ed9
Compare
fb69c27 to
972bd32
Compare
972bd32 to
2f87b6b
Compare
e4fd9ba to
6eae2f2
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @Yoni-Starkware)
crates/starknet_os_flow_tests/src/tests.rs line 2231 at r1 (raw file):
Previously, dorimedini-starkware wrote…
the original test subtracts exactly 10K, but it fails here, as the
get_available_gasreturns exactly 99990000, any ideas why? @meship-starkware
nvm... original test subtracts 1M, was missing a few zeros
rotem-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rotem-starkware reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @Yoni-Starkware)
6eae2f2 to
fb58ec6
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dorimedini-starkware reviewed 1 of 1 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @Yoni-Starkware)
rotem-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rotem-starkware reviewed 1 of 1 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @Yoni-Starkware)

No description provided.