Skip to content

Conversation

@dorimedini-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

dorimedini-starkware commented Oct 9, 2025

Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @Yoni-Starkware)


crates/starknet_os_flow_tests/src/tests.rs line 2231 at r1 (raw file):

    // L1 handler bounds test.
    let expected_l1_handler_gas_upper_bound = os_constants.l1_handler_max_amount_bounds.l2_gas.0;
    let expected_l1_handler_gas_lower_bound = expected_l1_handler_gas_upper_bound - 10001;

the original test subtracts exactly 10K, but it fails here, as the get_available_gas returns exactly 99990000, any ideas why? @meship-starkware

Code quote:

expected_l1_handler_gas_upper_bound - 10001;

@dorimedini-starkware dorimedini-starkware force-pushed the 10-08-starknet_os_flow_tests_migrate_test_block_info branch from 8a1fdf8 to 2787132 Compare October 9, 2025 09:39
@dorimedini-starkware dorimedini-starkware force-pushed the 10-09-starknet_os_flow_tests_migrate_test_initial_sierra_gas branch from 01b2f9d to c3db116 Compare October 9, 2025 09:39
@dorimedini-starkware dorimedini-starkware force-pushed the 10-08-starknet_os_flow_tests_migrate_test_block_info branch from 2787132 to 492b9c7 Compare October 9, 2025 09:49
@dorimedini-starkware dorimedini-starkware force-pushed the 10-09-starknet_os_flow_tests_migrate_test_initial_sierra_gas branch from c3db116 to 3ed646c Compare October 9, 2025 09:49
@dorimedini-starkware dorimedini-starkware force-pushed the 10-08-starknet_os_flow_tests_migrate_test_block_info branch from 492b9c7 to 6a5be89 Compare October 9, 2025 11:13
@dorimedini-starkware dorimedini-starkware force-pushed the 10-09-starknet_os_flow_tests_migrate_test_initial_sierra_gas branch from 3ed646c to 57c0e9e Compare October 9, 2025 11:13
@dorimedini-starkware dorimedini-starkware force-pushed the 10-08-starknet_os_flow_tests_migrate_test_block_info branch from 6a5be89 to 3050ce8 Compare October 9, 2025 11:47
@dorimedini-starkware dorimedini-starkware force-pushed the 10-09-starknet_os_flow_tests_migrate_test_initial_sierra_gas branch from 57c0e9e to cc9b30a Compare October 9, 2025 11:47
@dorimedini-starkware dorimedini-starkware force-pushed the 10-08-starknet_os_flow_tests_migrate_test_block_info branch from 3050ce8 to d26bb4a Compare October 9, 2025 12:59
@dorimedini-starkware dorimedini-starkware force-pushed the 10-09-starknet_os_flow_tests_migrate_test_initial_sierra_gas branch from cc9b30a to 8a6fcbe Compare October 9, 2025 12:59
@dorimedini-starkware dorimedini-starkware force-pushed the 10-08-starknet_os_flow_tests_migrate_test_block_info branch from d26bb4a to d0d082f Compare October 9, 2025 13:11
@dorimedini-starkware dorimedini-starkware force-pushed the 10-08-starknet_os_flow_tests_migrate_test_block_info branch from a20b5be to 2913251 Compare November 19, 2025 13:42
@dorimedini-starkware dorimedini-starkware force-pushed the 10-09-starknet_os_flow_tests_migrate_test_initial_sierra_gas branch from 2ff59a1 to 4cc533d Compare November 19, 2025 13:43
@dorimedini-starkware dorimedini-starkware force-pushed the 10-08-starknet_os_flow_tests_migrate_test_block_info branch from 2913251 to b36f6cd Compare November 20, 2025 09:28
@dorimedini-starkware dorimedini-starkware force-pushed the 10-09-starknet_os_flow_tests_migrate_test_initial_sierra_gas branch from 4cc533d to e868501 Compare November 20, 2025 09:28
@dorimedini-starkware dorimedini-starkware force-pushed the 10-08-starknet_os_flow_tests_migrate_test_block_info branch from b36f6cd to c4b1129 Compare November 20, 2025 10:47
@dorimedini-starkware dorimedini-starkware force-pushed the 10-09-starknet_os_flow_tests_migrate_test_initial_sierra_gas branch from e868501 to 9ab8181 Compare November 20, 2025 10:47
@dorimedini-starkware dorimedini-starkware force-pushed the 10-08-starknet_os_flow_tests_migrate_test_block_info branch from c4b1129 to 20e96e6 Compare November 20, 2025 12:03
@dorimedini-starkware dorimedini-starkware force-pushed the 10-09-starknet_os_flow_tests_migrate_test_initial_sierra_gas branch from 9ab8181 to fb69c27 Compare November 20, 2025 12:03
@dorimedini-starkware dorimedini-starkware force-pushed the 10-08-starknet_os_flow_tests_migrate_test_block_info branch from 20e96e6 to ac72ed9 Compare November 25, 2025 15:55
@dorimedini-starkware dorimedini-starkware force-pushed the 10-09-starknet_os_flow_tests_migrate_test_initial_sierra_gas branch from fb69c27 to 972bd32 Compare November 25, 2025 15:55
@dorimedini-starkware dorimedini-starkware force-pushed the 10-09-starknet_os_flow_tests_migrate_test_initial_sierra_gas branch from 972bd32 to 2f87b6b Compare November 26, 2025 19:34
@dorimedini-starkware dorimedini-starkware changed the base branch from 10-08-starknet_os_flow_tests_migrate_test_block_info to main-v0.14.1-committer November 26, 2025 19:34
@dorimedini-starkware dorimedini-starkware force-pushed the 10-09-starknet_os_flow_tests_migrate_test_initial_sierra_gas branch 3 times, most recently from e4fd9ba to 6eae2f2 Compare December 2, 2025 10:57
Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @Yoni-Starkware)


crates/starknet_os_flow_tests/src/tests.rs line 2231 at r1 (raw file):

Previously, dorimedini-starkware wrote…

the original test subtracts exactly 10K, but it fails here, as the get_available_gas returns exactly 99990000, any ideas why? @meship-starkware

nvm... original test subtracts 1M, was missing a few zeros

Copy link
Contributor

@rotem-starkware rotem-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@rotem-starkware reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @Yoni-Starkware)

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue Dec 2, 2025
@dorimedini-starkware dorimedini-starkware removed this pull request from the merge queue due to a manual request Dec 2, 2025
@dorimedini-starkware dorimedini-starkware force-pushed the 10-09-starknet_os_flow_tests_migrate_test_initial_sierra_gas branch from 6eae2f2 to fb58ec6 Compare December 2, 2025 11:56
Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @Yoni-Starkware)

Copy link
Contributor

@rotem-starkware rotem-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rotem-starkware reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @Yoni-Starkware)

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue Dec 2, 2025
Merged via the queue into main-v0.14.1-committer with commit d919edd Dec 2, 2025
17 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants