starknet_os_flow_tests: migrate test_deprecated_tx_info

[dorimedini-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[dorimedini-starkware]

• starknet_os_flow_tests: migrate test_initial_sierra_gas #9539 : 2 dependent PRs (#9544 , #9546 )
• starknet_os_flow_tests: migrate test_block_info #9529
• blockifier_test_utils: add block_info_test_contract contracts #9528
• starknet_os_flow_tests: migrate test_deploy_syscall #9527
• starknet_os_flow_tests: migrate test_deprecated_tx_info #9525 👈 (View in Graphite)
• blockifier_test_utils: add tx_info_writer cairo0 contract #9524
• starknet_os_flow_tests: rename test #9823
• starknet_os_flow_tests: split test_new_class_flow new account flow #9822
• starknet_os_flow_tests: split test_new_class_flow experimental contract flow #9821
• starknet_os_flow_tests: split test_new_class_flow exec-info txs #9820
• starknet_os_flow_tests: use nonce as deployment salt #9819
• starknet_os_flow_tests: implement get_builtin_usage #9818
• starknet_os_flow_tests: implement update_expected_storage_updates_for_block_hash_contract #9817
• starknet_os_flow_tests: migrate test_new_class_flow #9518
• starknet_os_flow_tests: add update_expected_storage util #9805
• blockifier_test_utils: add experimental contract and it's libfuncs list #9517
• blockifier_test_utils: put tx hash in signature for exec info tests #9516
• blockifier: extract get_expected_execution_info to function #9515
• blockifier: update test contract for test_new_contract_flow #9514
• main-v0.14.1-committer

This stack of pull requests is managed by Graphite. Learn more about stacking.

[rotem-starkware]

@rotem-starkware reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @AvivYossef-starkware, @meship-starkware, and @Yoni-Starkware)

---

crates/starknet_os_flow_tests/src/tests.rs line 1624 at r1 (raw file):

    let tx_info_writer = FeatureContract::TxInfoWriter;
    let class_hash = get_class_hash_of_feature_contract(tx_info_writer);
    // Initialize the test manager with the tx info writer already declared.

When it's declared?

---

crates/starknet_os_flow_tests/src/tests.rs line 1625 at r1 (raw file):

    let class_hash = get_class_hash_of_feature_contract(tx_info_writer);
    // Initialize the test manager with the tx info writer already declared.
    // We can ignore the address of the dpeloyed instance.

// We can ignore the address of the deployed instance.

Code quote:

// We can ignore the address of the dpeloyed instance.

---

crates/starknet_os_flow_tests/src/tests.rs line 1727 at r1 (raw file):

        Transaction::Account(AccountTransaction::Declare(declare_tx)),
        Transaction::L1Handler(l1_handler_tx),
    ] {

IIUC in the python test we check also the first declare tx (of the contract) and the fund tx.
Is it not required?

---

crates/starknet_os_flow_tests/src/tests.rs line 1749 at r1 (raw file):

            contract_storage_updates
                .insert(get_storage_var_address("version", tx_type), Felt::ZERO);
        }

I think the inverse condition is more readable:

if matches!(tx.tx_type(), TransactionType::L1Handler) {
            contract_storage_updates
                .insert(get_storage_var_address("version", tx_type), Felt::ZERO);
        } else {
            contract_storage_updates
                .insert(get_storage_var_address("version", tx_type), tx.version().0);
        }

Code quote:

        if !matches!(tx.tx_type(), TransactionType::L1Handler) {
            contract_storage_updates
                .insert(get_storage_var_address("version", tx_type), tx.version().0);
        } else {
            contract_storage_updates
                .insert(get_storage_var_address("version", tx_type), Felt::ZERO);
        }

---

crates/starknet_os_flow_tests/src/tests.rs line 1767 at r1 (raw file):

    );
    test_output.assert_account_balance_change(tx_info_account_address);
    test_output.assert_account_balance_change(contract_address!(TEST_SEQUENCER_ADDRESS));

Do we need to check that the account balance of the funding account changed?

[dorimedini-starkware]

Reviewable status: 0 of 1 files reviewed, 4 unresolved discussions (waiting on @AvivYossef-starkware, @meship-starkware, @rotem-starkware, and @Yoni-Starkware)

---

crates/starknet_os_flow_tests/src/tests.rs line 1624 at r1 (raw file):

Previously, rotem-starkware wrote…

When it's declared?

when calling new_with_default_initial_state, you can pass contracts you want to (declare and) deploy as part of the initial state. that's what I mean: I declare and deploy the tx info writer, but I ignore the deployed instance and deploy again as part ofthe OS flow test (the initial state does not get proven by the OS).

---

crates/starknet_os_flow_tests/src/tests.rs line 1625 at r1 (raw file):

Previously, rotem-starkware wrote…

// We can ignore the address of the deployed instance.

Done.

---

crates/starknet_os_flow_tests/src/tests.rs line 1727 at r1 (raw file):

Previously, rotem-starkware wrote…

IIUC in the python test we check also the first declare tx (of the contract) and the fund tx.
Is it not required?

the contract is not declared in this block.
if this contract was special (in the sense that it would be interesting to see that the OS can process it's declare tx), then I would say it's important to run it in the block, but it doesn't have any special syscalls or anything

---

crates/starknet_os_flow_tests/src/tests.rs line 1749 at r1 (raw file):

Previously, rotem-starkware wrote…

I think the inverse condition is more readable:

if matches!(tx.tx_type(), TransactionType::L1Handler) {
            contract_storage_updates
                .insert(get_storage_var_address("version", tx_type), Felt::ZERO);
        } else {
            contract_storage_updates
                .insert(get_storage_var_address("version", tx_type), tx.version().0);
        }

done (and removed some duplication while i'm there)

---

crates/starknet_os_flow_tests/src/tests.rs line 1767 at r1 (raw file):

Previously, rotem-starkware wrote…

Do we need to check that the account balance of the funding account changed?

Done.

[rotem-starkware]

@rotem-starkware reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware, @meship-starkware, and @Yoni-Starkware)