starknet_os_flow_tests: migrate test_block_info

[dorimedini-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[dorimedini-starkware]

• starknet_os_flow_tests: migrate test_initial_sierra_gas #9539 : 2 dependent PRs (#9544 , #9546 )
• starknet_os_flow_tests: migrate test_block_info #9529 👈 (View in Graphite)
• blockifier_test_utils: add block_info_test_contract contracts #9528
• starknet_os_flow_tests: migrate test_deploy_syscall #9527
• starknet_os_flow_tests: migrate test_deprecated_tx_info #9525
• blockifier_test_utils: add tx_info_writer cairo0 contract #9524
• starknet_os_flow_tests: rename test #9823
• starknet_os_flow_tests: split test_new_class_flow new account flow #9822
• starknet_os_flow_tests: split test_new_class_flow experimental contract flow #9821
• starknet_os_flow_tests: split test_new_class_flow exec-info txs #9820
• starknet_os_flow_tests: use nonce as deployment salt #9819
• starknet_os_flow_tests: implement get_builtin_usage #9818
• starknet_os_flow_tests: implement update_expected_storage_updates_for_block_hash_contract #9817
• starknet_os_flow_tests: migrate test_new_class_flow #9518
• starknet_os_flow_tests: add update_expected_storage util #9805
• blockifier_test_utils: add experimental contract and it's libfuncs list #9517
• blockifier_test_utils: put tx hash in signature for exec info tests #9516
• blockifier: extract get_expected_execution_info to function #9515
• blockifier: update test contract for test_new_contract_flow #9514
• main-v0.14.1-committer

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Benchmark movements: full_committer_flow performance improved 😺 full_committer_flow time: [16.136 ms 16.269 ms 16.408 ms] change: [-7.6444% -6.0254% -4.5131%] (p = 0.00 < 0.05) Performance has improved. Found 2 outliers among 100 measurements (2.00%) 2 (2.00%) high mild

[rotem-starkware]

@rotem-starkware reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @AvivYossef-starkware, @meship-starkware, and @Yoni-Starkware)

---

crates/starknet_os_flow_tests/src/tests.rs line 1907 at r3 (raw file):

            DeclareTransaction::create(account_declare_tx, class_info, &CHAIN_ID_FOR_TESTS)
                .unwrap();
        test_manager.add_cairo1_declare_tx(declare_tx.clone(), &test_contract_sierra);

Is the cloning necessary here?

---

crates/starknet_os_flow_tests/src/tests.rs line 1946 at r3 (raw file):

    let empty_compiled_class_hash = empty_contract.get_compiled_class_hash(&HashVersion::V2);
    let declare_tx_args = declare_tx_args! {
        sender_address: block_info_account_address,

It's not like the python test, but I think it's correct.
IIUC we want to test __validate_declare__ of block_info_test_contract, so we need to send this tx from block_info_account_address.
@Yoni-Starkware can you PTAL?

Code quote:

sender_address: block_info_account_address,

---

crates/starknet_os_flow_tests/src/tests.rs line 1970 at r3 (raw file):

    // Test `constructor` in execute mode.
    let ctor_calldata = [Felt::ZERO]; // Not validate mode (execute mode).
    let salt = Felt::ZERO;

python

Suggestion:

let salt = Felt::ONE

[dorimedini-starkware]

Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @AvivYossef-starkware, @meship-starkware, @rotem-starkware, and @Yoni-Starkware)

---

crates/starknet_os_flow_tests/src/tests.rs line 1907 at r3 (raw file):

Previously, rotem-starkware wrote…

Is the cloning necessary here?

Done.

---

crates/starknet_os_flow_tests/src/tests.rs line 1970 at r3 (raw file):

Previously, rotem-starkware wrote…

python

Done.

[Yoni-Starkware]

Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @AvivYossef-starkware, @meship-starkware, and @rotem-starkware)

---

crates/starknet_os_flow_tests/src/tests.rs line 1946 at r3 (raw file):

Previously, rotem-starkware wrote…

It's not like the python test, but I think it's correct.
IIUC we want to test __validate_declare__ of block_info_test_contract, so we need to send this tx from block_info_account_address.
@Yoni-Starkware can you PTAL?

Right, bug in py test

[Yoni-Starkware]

Reviewable status: 0 of 1 files reviewed, 4 unresolved discussions (waiting on @AvivYossef-starkware, @meship-starkware, and @rotem-starkware)

---

a discussion (no related file):
Non-blocking, no need to be in this PR. Can you add the following asserts to the test contracts in execute mode?

            assert (block_number != block_number_for_validate, 'INVALID_BLOCK_NUMBER');
            assert (block_timestamp != block_timestamp_for_validate, 'INVALID_BLOCK_TIMESTAMP');

Here

        if is_validate {
            assert (block_number == block_number_for_validate, 'INVALID_BLOCK_NUMBER');
            assert (block_timestamp == block_timestamp_for_validate, 'INVALID_BLOCK_TIMESTAMP');
            return starknet::VALIDATED;
        }
        assert (!is_validate, 'INVALID_IS_VALIDATE');
        // Here

[dorimedini-starkware]

Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @AvivYossef-starkware, @meship-starkware, and @rotem-starkware)

---

a discussion (no related file):

Previously, Yoni-Starkware (Yoni) wrote…

Non-blocking, no need to be in this PR. Can you add the following asserts to the test contracts in execute mode?

            assert (block_number != block_number_for_validate, 'INVALID_BLOCK_NUMBER');
            assert (block_timestamp != block_timestamp_for_validate, 'INVALID_BLOCK_TIMESTAMP');

Here

        if is_validate {
            assert (block_number == block_number_for_validate, 'INVALID_BLOCK_NUMBER');
            assert (block_timestamp == block_timestamp_for_validate, 'INVALID_BLOCK_TIMESTAMP');
            return starknet::VALIDATED;
        }
        assert (!is_validate, 'INVALID_IS_VALIDATE');
        // Here

done (top of stack)

---

crates/starknet_os_flow_tests/src/tests.rs line 1946 at r3 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Right, bug in py test

Done.

[rotem-starkware]

@rotem-starkware reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware and @meship-starkware)