Skip to content

Conversation

@dorimedini-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

dorimedini-starkware commented Oct 6, 2025

@dorimedini-starkware dorimedini-starkware self-assigned this Oct 6, 2025
@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review October 6, 2025 17:26
@dorimedini-starkware dorimedini-starkware force-pushed the 10-05-blockifier_extract_get_expected_execution_info_to_function branch from 4a01137 to 0c893d7 Compare October 6, 2025 18:12
@dorimedini-starkware dorimedini-starkware force-pushed the 10-06-blockifier_test_utils_put_tx_hash_in_signature_for_exec_info_tests branch 4 times, most recently from 3348213 to 71c984f Compare October 8, 2025 07:48
Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Yoni-Starkware reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware and @meship-starkware)

@dorimedini-starkware dorimedini-starkware force-pushed the 10-05-blockifier_extract_get_expected_execution_info_to_function branch from 0c893d7 to b1c1a13 Compare October 8, 2025 13:31
@dorimedini-starkware dorimedini-starkware force-pushed the 10-06-blockifier_test_utils_put_tx_hash_in_signature_for_exec_info_tests branch from 71c984f to d950b7c Compare October 8, 2025 13:31
@dorimedini-starkware dorimedini-starkware force-pushed the 10-05-blockifier_extract_get_expected_execution_info_to_function branch from b1c1a13 to bc5242e Compare October 8, 2025 13:44
@dorimedini-starkware dorimedini-starkware force-pushed the 10-06-blockifier_test_utils_put_tx_hash_in_signature_for_exec_info_tests branch from d950b7c to 950214d Compare October 8, 2025 13:44
@dorimedini-starkware dorimedini-starkware force-pushed the 10-05-blockifier_extract_get_expected_execution_info_to_function branch from bc5242e to 3bc279e Compare October 8, 2025 13:48
@dorimedini-starkware dorimedini-starkware force-pushed the 10-06-blockifier_test_utils_put_tx_hash_in_signature_for_exec_info_tests branch from 950214d to bd5cac9 Compare October 8, 2025 13:48
@dorimedini-starkware dorimedini-starkware force-pushed the 10-05-blockifier_extract_get_expected_execution_info_to_function branch from 3bc279e to 02d9fbe Compare October 8, 2025 13:55
@dorimedini-starkware dorimedini-starkware force-pushed the 10-06-blockifier_test_utils_put_tx_hash_in_signature_for_exec_info_tests branch from bd5cac9 to 77414b0 Compare October 8, 2025 13:55
@dorimedini-starkware dorimedini-starkware force-pushed the 10-05-blockifier_extract_get_expected_execution_info_to_function branch from 02d9fbe to c1dbd61 Compare October 8, 2025 14:56
@dorimedini-starkware dorimedini-starkware force-pushed the 10-06-blockifier_test_utils_put_tx_hash_in_signature_for_exec_info_tests branch from 77414b0 to 6c0008e Compare October 8, 2025 14:56
@dorimedini-starkware dorimedini-starkware force-pushed the 10-05-blockifier_extract_get_expected_execution_info_to_function branch from bce99b6 to 98dac2a Compare October 23, 2025 12:44
@dorimedini-starkware dorimedini-starkware force-pushed the 10-06-blockifier_test_utils_put_tx_hash_in_signature_for_exec_info_tests branch from cd1d738 to d96bbb6 Compare October 23, 2025 12:45
@dorimedini-starkware dorimedini-starkware force-pushed the 10-05-blockifier_extract_get_expected_execution_info_to_function branch from 98dac2a to 46ff0b0 Compare October 26, 2025 08:27
@dorimedini-starkware dorimedini-starkware force-pushed the 10-06-blockifier_test_utils_put_tx_hash_in_signature_for_exec_info_tests branch from d96bbb6 to bd48aa2 Compare October 26, 2025 08:27
@dorimedini-starkware dorimedini-starkware force-pushed the 10-05-blockifier_extract_get_expected_execution_info_to_function branch from 46ff0b0 to 532ee37 Compare October 28, 2025 08:51
@dorimedini-starkware dorimedini-starkware force-pushed the 10-06-blockifier_test_utils_put_tx_hash_in_signature_for_exec_info_tests branch from bd48aa2 to 2615041 Compare October 28, 2025 08:51
@dorimedini-starkware dorimedini-starkware force-pushed the 10-05-blockifier_extract_get_expected_execution_info_to_function branch from 532ee37 to 01b132f Compare October 28, 2025 14:11
@dorimedini-starkware dorimedini-starkware force-pushed the 10-06-blockifier_test_utils_put_tx_hash_in_signature_for_exec_info_tests branch from 2615041 to 30942c2 Compare October 28, 2025 14:11
Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 of 6 files at r1, 7 of 7 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware and @meship-starkware)

@dorimedini-starkware dorimedini-starkware force-pushed the 10-05-blockifier_extract_get_expected_execution_info_to_function branch from 01b132f to 77ba652 Compare November 3, 2025 07:55
@dorimedini-starkware dorimedini-starkware force-pushed the 10-06-blockifier_test_utils_put_tx_hash_in_signature_for_exec_info_tests branch from 30942c2 to 76f08ff Compare November 3, 2025 07:55
@dorimedini-starkware dorimedini-starkware force-pushed the 10-05-blockifier_extract_get_expected_execution_info_to_function branch from 77ba652 to 81246a4 Compare November 9, 2025 15:26
@dorimedini-starkware dorimedini-starkware force-pushed the 10-06-blockifier_test_utils_put_tx_hash_in_signature_for_exec_info_tests branch from 76f08ff to 0902177 Compare November 9, 2025 15:26
@dorimedini-starkware dorimedini-starkware changed the base branch from 10-05-blockifier_extract_get_expected_execution_info_to_function to main-v0.14.1-committer November 12, 2025 09:49
@dorimedini-starkware dorimedini-starkware force-pushed the 10-06-blockifier_test_utils_put_tx_hash_in_signature_for_exec_info_tests branch from 0902177 to 0658db0 Compare November 12, 2025 09:52
@graphite-app
Copy link

graphite-app bot commented Nov 12, 2025

Merge activity

  • Nov 12, 9:52 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue Nov 12, 2025
Merged via the queue into main-v0.14.1-committer with commit 6a2e2a9 Nov 12, 2025
24 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants