Skip to content

Conversation

@dorimedini-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

dorimedini-starkware commented Sep 30, 2025

@dorimedini-starkware dorimedini-starkware self-assigned this Sep 30, 2025
@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review September 30, 2025 10:42
Copy link
Collaborator

@amosStarkware amosStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amosStarkware reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)


crates/starknet_os_flow_tests/src/test_manager.rs line 119 at r1 (raw file):

    pub(crate) fn perform_default_validations(&self) {
        self.perform_validations(true, None);
    }

It would be nice to have named variables for the parameters. non blocking

Code quote:

    pub(crate) fn perform_default_validations(&self) {
        self.perform_validations(true, None);
    }

@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants