-
Notifications
You must be signed in to change notification settings - Fork 65
starknet_os_flow_tests: reduce boilerplate with perform_default_validations #9472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
starknet_os_flow_tests: reduce boilerplate with perform_default_validations #9472
Conversation
amosStarkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amosStarkware reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)
crates/starknet_os_flow_tests/src/test_manager.rs line 119 at r1 (raw file):
pub(crate) fn perform_default_validations(&self) { self.perform_validations(true, None); }
It would be nice to have named variables for the parameters. non blocking
Code quote:
pub(crate) fn perform_default_validations(&self) {
self.perform_validations(true, None);
}
No description provided.