starknet_os_flow_tests: split get_class_info_of_cairo0_contract into function #9492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 5, 2025
|
This change is |
This was referenced Oct 5, 2025
Collaborator
Author
This was referenced Oct 5, 2025
dorimedini-starkware
requested review from
AvivYossef-starkware,
Yoni-Starkware and
meship-starkware
dorimedini-starkware
force-pushed
the
10-02-starknet_os_flow_tests_more_informative_execution_failure
branch
from
d94fb8f to
e7a7b06
Compare
dorimedini-starkware
force-pushed
the
10-02-starknet_os_flow_tests_split_get_class_info_of_cairo0_contract_into_function
branch
from
210b6e4 to
d3f102a
Compare
dorimedini-starkware
force-pushed
the
10-02-starknet_os_flow_tests_more_informative_execution_failure
branch
from
e7a7b06 to
0b0cf38
Compare
dorimedini-starkware
force-pushed
the
10-02-starknet_os_flow_tests_split_get_class_info_of_cairo0_contract_into_function
branch
from
d3f102a to
9594067
Compare
This was referenced Oct 6, 2025
This was referenced Oct 11, 2025
dorimedini-starkware
force-pushed
the
10-02-starknet_os_flow_tests_more_informative_execution_failure
branch
from
1a0c720 to
65f994c
Compare
dorimedini-starkware
force-pushed
the
10-02-starknet_os_flow_tests_split_get_class_info_of_cairo0_contract_into_function
branch
from
f4e57f8 to
56bd729
Compare
dorimedini-starkware
force-pushed
the
10-02-starknet_os_flow_tests_more_informative_execution_failure
branch
from
65f994c to
55e910c
Compare
dorimedini-starkware
force-pushed
the
10-02-starknet_os_flow_tests_split_get_class_info_of_cairo0_contract_into_function
branch
from
56bd729 to
27de36e
Compare
dorimedini-starkware
force-pushed
the
10-02-starknet_os_flow_tests_more_informative_execution_failure
branch
from
55e910c to
92d97ac
Compare
dorimedini-starkware
force-pushed
the
10-02-starknet_os_flow_tests_split_get_class_info_of_cairo0_contract_into_function
branch
from
27de36e to
4306e5d
Compare
dorimedini-starkware
force-pushed
the
10-02-starknet_os_flow_tests_more_informative_execution_failure
branch
3 times, most recently
from
3b57877 to
04e5627
Compare
dorimedini-starkware
force-pushed
the
10-02-starknet_os_flow_tests_split_get_class_info_of_cairo0_contract_into_function
branch
from
4306e5d to
7d4aa74
Compare
meship-starkware
approved these changes
Oct 23, 2025
Collaborator
meship-starkware
left a comment
meship-starkware
left a comment
There was a problem hiding this comment.
@meship-starkware reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware and @Yoni-Starkware)
meship-starkware
approved these changes
Oct 23, 2025
Collaborator
meship-starkware
left a comment
meship-starkware
left a comment
There was a problem hiding this comment.
Reviewable status:
dorimedini-starkware
changed the base branch from
10-02-starknet_os_flow_tests_more_informative_execution_failure
to
main
|
Artifacts upload workflows: |
Collaborator
meship-starkware
left a comment
meship-starkware
left a comment
There was a problem hiding this comment.
@meship-starkware reviewed 1 of 7 files at r4.
Reviewable status: 1 of 7 files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @Yoni-Starkware)
-- commits line 12 at r4:
Plese rebase
Code quote:
New commits in r4 on 22/10/2025 at 18:58:
- 661ee19: starknet_os_flow_tests: localize expected storage updates in test_os_logic
- 003de2c: starknet_os_flow_tests: add V1-bound cairo0 account for flow tests
- 04e5627: starknet_os_flow_tests: more informative execution failure
- 7d4aa74: starknet_os_flow_tests: split get_class_info_of_cairo0_contract into function
|
Benchmark movements: No major performance changes detected. |
dorimedini-starkware
force-pushed
the
10-02-starknet_os_flow_tests_split_get_class_info_of_cairo0_contract_into_function
branch
from
7d4aa74 to
56050a5
Compare
Collaborator
Author
dorimedini-starkware
left a comment
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed 7 of 7 files at r5, all commit messages.
Reviewable status:
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.