starknet_os_flow_tests: migrate test_v1_bound_accounts_cairo0

[dorimedini-starkware]

No description provided.

[github-actions]

Artifacts upload workflows:

• Started at 2025-10-05T07:45:51Z
• Started at 2025-10-05T07:52:25Z
• Started at 2025-10-05T09:38:33Z
• Started at 2025-10-06T16:51:36Z
• Started at 2025-10-09T09:34:16Z
• Started at 2025-10-09T09:47:31Z
• Started at 2025-10-09T11:11:17Z
• Started at 2025-10-14T10:22:11Z
• Started at 2025-10-15T11:18:24Z
• Started at 2025-10-19T18:43:02Z
• Started at 2025-10-22T15:59:22Z
• Started at 2025-10-23T10:12:43Z
• Started at 2025-10-23T10:26:12Z

[dorimedini-starkware]

• starknet_os_flow_tests: migrate test_v1_bound_accounts_cairo1 #9496 : 2 dependent PRs (#9501 , #9514 )
• starknet_os_flow_tests: add V1-bound cairo1 account for flow tests #9495
• starknet_api: fix compiler->SNAPI contract class ABI string conversion for tests #9494
• starknet_os_flow_tests: migrate test_v1_bound_accounts_cairo0 #9493 👈 (View in Graphite)
• starknet_os_flow_tests: split get_class_info_of_cairo0_contract into function #9492
• starknet_os_flow_tests: more informative execution failure #9491
• starknet_os_flow_tests: add V1-bound cairo0 account for flow tests #9490
• starknet_os_flow_tests: localize expected storage updates in test_os_logic #9485
• starknet_os_flow_tests: migrate test_os_logic and some small refactors #9484
• blockifier_test_utils: add functionality to test contract for test_os_logic #9483
• blockifier_test_utils: add test_contract2 cairo0 contract #9482
• blockifier_test_utils: add delegate_proxy cairo0 contract #9481
• starknet_os_flow_tests: add control for expected reverting txs #9480
• starknet_os_flow_tests: migrate test_reverted_l1_handler_tx #9474
• starknet_os_flow_tests: reduce boilerplate with add_funded_account_invoke #9563
• starknet_os_flow_tests: move nonce manager into test manager #9562
• starknet_os_flow_tests: migrate test_reverted_invoke_tx #9473
• starknet_os_flow_tests: reduce boilerplate with perform_default_validations #9472
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[reviewable-StarkWare]

This change is 

[github-actions]

Benchmark movements: No major performance changes detected.

[meship-starkware]

@meship-starkware reviewed 1 of 3 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @AvivYossef-starkware and @Yoni-Starkware)

---

crates/starknet_os_flow_tests/src/tests.rs line 807 at r2 (raw file):

    let declare_args = declare_tx_args! {
        version: TransactionVersion::ZERO,
        max_fee: Fee(1_000_000_000_000_000),

Is it necessary? AFAIK Tx version 0 does not have a max fee

Suggestion:

 max_fee: Fee(1_000_000_000_000_000),   

---

crates/starknet_os_flow_tests/src/tests.rs line 856 at r2 (raw file):

        signature: TransactionSignature(Arc::new(vec![r, s])),
        ..validate_tx_args
    };

Please add the doc as to why we create the signature after the tx here

Code quote:

    let Signature { r, s } = ecdsa_sign(&private_key, &validate_tx.tx_hash()).unwrap().into();
    let validate_tx_args = invoke_tx_args! {
        signature: TransactionSignature(Arc::new(vec![r, s])),
        ..validate_tx_args
    };

[meship-starkware]

@meship-starkware reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @AvivYossef-starkware, @dorimedini-starkware, and @Yoni-Starkware)

[dorimedini-starkware]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @AvivYossef-starkware, @meship-starkware, and @Yoni-Starkware)

---

crates/starknet_os_flow_tests/src/tests.rs line 807 at r2 (raw file):

Previously, meship-starkware (Meshi Peled) wrote…

Is it necessary? AFAIK Tx version 0 does not have a max fee

I see that it does have max_fee, because the type used is DeclareTransactionV0V1.
I don't think it matters, we are not trying to test fees here

---

crates/starknet_os_flow_tests/src/tests.rs line 856 at r2 (raw file):

Previously, meship-starkware (Meshi Peled) wrote…

Please add the doc as to why we create the signature after the tx here

there is an explanation above:

    // Create a validate tx and add signature to the transaction. The dummy account used to call
    // `__validate__` does not check the signature, so we can use the signature field for
    // `__validate__`. This is done after creating the transaction so that we will have access
    // to the transaction hash.

is it unclear? we need to sign the tx hash, it's easier to first create the entire tx and then compute the signature

[meship-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware and @Yoni-Starkware)

---

crates/starknet_os_flow_tests/src/tests.rs line 856 at r2 (raw file):

Previously, dorimedini-starkware wrote…

there is an explanation above:

    // Create a validate tx and add signature to the transaction. The dummy account used to call
    // `__validate__` does not check the signature, so we can use the signature field for
    // `__validate__`. This is done after creating the transaction so that we will have access
    // to the transaction hash.

is it unclear? we need to sign the tx hash, it's easier to first create the entire tx and then compute the signature

No, this is fine. I simply missed it

[dorimedini-starkware]

@dorimedini-starkware reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware and @Yoni-Starkware)