starknet_os: allow full OS output with variable full_output flag

[dorimedini-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[dorimedini-starkware]

• starknet_os: migrate test_parse_and_output #10362
• apollo_starknet_os_program: reorder implicit builtins into the expected order #10361
• starknet_os: allow full OS output with variable full_output flag #10360 👈 (View in Graphite)
• starknet_os: split out FullOsOutputs parsing logic #10359
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Yoni-Starkware]

@Yoni-Starkware reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @TzahiTaub)

---

crates/starknet_os/src/hints/hint_implementation/aggregator/utils.rs line 256 at r1 (raw file):

    let class_dict_ptr_start = state_diff_writer.get_class_dict_ptr();
    state_diff_writer.write_classes_changes(&state_diff.classes, vm)?;

This is written in a full output format, always. Are you going to change that? what is the motivation of passing the flag then?

Code quote:

    let state_dict_ptr_start = state_diff_writer.get_state_dict_ptr();
    state_diff_writer.write_contract_changes(&state_diff.contracts, vm)?;

    let class_dict_ptr_start = state_diff_writer.get_class_dict_ptr();
    state_diff_writer.write_classes_changes(&state_diff.classes, vm)?;

[dorimedini-starkware]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @TzahiTaub and @Yoni-Starkware)

---

crates/starknet_os/src/hints/hint_implementation/aggregator/utils.rs line 256 at r1 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

This is written in a full output format, always. Are you going to change that? what is the motivation of passing the flag then?

used here.
IIUC this just changes the boolean felt representing the flag... the original test had this logic and I was under the impression that the OS diffs are always full-ouptut, but the aggregator output also has this flag as part of it's output (though the value is ignored...?)

[Yoni-Starkware]

@Yoni-Starkware reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub)

---

crates/starknet_os/src/hints/hint_implementation/aggregator/utils.rs line 256 at r1 (raw file):

Previously, dorimedini-starkware wrote…

used here.
IIUC this just changes the boolean felt representing the flag... the original test had this logic and I was under the impression that the OS diffs are always full-ouptut, but the aggregator output also has this flag as part of it's output (though the value is ignored...?)

Okay, since it's only for tests...