-
Notifications
You must be signed in to change notification settings - Fork 65
starknet_os: migrate test_parse_and_output #10362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
starknet_os: migrate test_parse_and_output #10362
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
60044ad to
58101e9
Compare
d859a90 to
4df1ff1
Compare
58101e9 to
c134f93
Compare
4df1ff1 to
ac8962b
Compare
c134f93 to
ff5b4d9
Compare
ac8962b to
fe8368b
Compare
ff5b4d9 to
9417bf2
Compare
fe8368b to
6bfd4f2
Compare
9417bf2 to
49eb1da
Compare
6bfd4f2 to
1f41087
Compare
b2e8bb4 to
a21d0c8
Compare
|
Artifacts upload workflows: |
a21d0c8 to
e6975ca
Compare
amosStarkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amosStarkware reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware, @TzahiTaub, and @Yoni-Starkware)
crates/starknet_os/src/hints/hint_implementation/aggregator/test.rs line 724 at r2 (raw file):
else { panic!("Unexpected implicit return value structure, got: {implicit_return_values:?}."); };
The Python test verifies something about the builtin usage - you didn't do it here because it tests the cairo runner, right?
Code quote:
let [EndpointArg::Value(ValueArg::Array(output_array)), _rc, _ec, _poseidon] =
implicit_return_values.as_slice()
else {
panic!("Unexpected implicit return value structure, got: {implicit_return_values:?}.");
};
amosStarkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub and @Yoni-Starkware)

No description provided.