Skip to content

Conversation

@dorimedini-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

dorimedini-starkware commented Nov 23, 2025

@dorimedini-starkware dorimedini-starkware self-assigned this Nov 23, 2025
@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review November 23, 2025 15:59
@dorimedini-starkware dorimedini-starkware force-pushed the 11-23-starknet_os_migrate_test_parse_and_output branch from 60044ad to 58101e9 Compare November 23, 2025 16:17
@dorimedini-starkware dorimedini-starkware force-pushed the 11-23-apollo_starknet_os_program_reorder_implicit_builtins_into_the_expected_order branch from d859a90 to 4df1ff1 Compare December 6, 2025 10:53
@dorimedini-starkware dorimedini-starkware force-pushed the 11-23-starknet_os_migrate_test_parse_and_output branch from 58101e9 to c134f93 Compare December 6, 2025 10:53
@dorimedini-starkware dorimedini-starkware force-pushed the 11-23-apollo_starknet_os_program_reorder_implicit_builtins_into_the_expected_order branch from 4df1ff1 to ac8962b Compare December 7, 2025 10:30
@dorimedini-starkware dorimedini-starkware force-pushed the 11-23-starknet_os_migrate_test_parse_and_output branch from c134f93 to ff5b4d9 Compare December 7, 2025 10:30
@dorimedini-starkware dorimedini-starkware force-pushed the 11-23-apollo_starknet_os_program_reorder_implicit_builtins_into_the_expected_order branch from ac8962b to fe8368b Compare December 7, 2025 14:54
@dorimedini-starkware dorimedini-starkware force-pushed the 11-23-starknet_os_migrate_test_parse_and_output branch from ff5b4d9 to 9417bf2 Compare December 7, 2025 14:55
@dorimedini-starkware dorimedini-starkware force-pushed the 11-23-apollo_starknet_os_program_reorder_implicit_builtins_into_the_expected_order branch from fe8368b to 6bfd4f2 Compare December 10, 2025 09:20
@dorimedini-starkware dorimedini-starkware force-pushed the 11-23-starknet_os_migrate_test_parse_and_output branch from 9417bf2 to 49eb1da Compare December 10, 2025 09:21
@dorimedini-starkware dorimedini-starkware force-pushed the 11-23-apollo_starknet_os_program_reorder_implicit_builtins_into_the_expected_order branch from 6bfd4f2 to 1f41087 Compare December 11, 2025 10:40
@dorimedini-starkware dorimedini-starkware force-pushed the 11-23-starknet_os_migrate_test_parse_and_output branch 2 times, most recently from b2e8bb4 to a21d0c8 Compare December 11, 2025 14:53
@dorimedini-starkware dorimedini-starkware changed the base branch from 11-23-apollo_starknet_os_program_reorder_implicit_builtins_into_the_expected_order to main December 11, 2025 14:53
@github-actions
Copy link

Artifacts upload workflows:

@dorimedini-starkware dorimedini-starkware force-pushed the 11-23-starknet_os_migrate_test_parse_and_output branch from a21d0c8 to e6975ca Compare December 16, 2025 09:52
Copy link
Collaborator

@amosStarkware amosStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amosStarkware reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware, @TzahiTaub, and @Yoni-Starkware)


crates/starknet_os/src/hints/hint_implementation/aggregator/test.rs line 724 at r2 (raw file):

    else {
        panic!("Unexpected implicit return value structure, got: {implicit_return_values:?}.");
    };

The Python test verifies something about the builtin usage - you didn't do it here because it tests the cairo runner, right?

Code quote:

    let [EndpointArg::Value(ValueArg::Array(output_array)), _rc, _ec, _poseidon] =
        implicit_return_values.as_slice()
    else {
        panic!("Unexpected implicit return value structure, got: {implicit_return_values:?}.");
    };

Copy link
Collaborator

@amosStarkware amosStarkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub and @Yoni-Starkware)

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue Dec 16, 2025
Merged via the queue into main with commit fb32b6e Dec 16, 2025
18 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants