blockifier_reexecution: refactor get block header

[AvivYossef-starkware]

No description provided.

[AvivYossef-starkware]

• starknet_os_runner: aviv refactor the rpc state reader to compute the compiled class hash #11302
• starknet_os_runner: base block info #11295
• blockifier_reexecution: refactor get block header #11374 👈 (View in Graphite)
• apollo_gateway: add missing fields to block header #11373
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[reviewable-StarkWare]

This change is 

[AvivYossef-starkware]

@AvivYossef-starkware made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @avi-starkware and @noaov1).

---

crates/blockifier_reexecution/src/state_reader/rpc_state_reader.rs line 257 at r1 (raw file):

                })?,
            );
        }

I tested it, and it is unnecessary when using rpc-v0.10, even for old blocks.

Code quote:

        if block_header_map.get("l2_gas_price").is_none() {
            // In old blocks, the l2_gas_price field is not present.
            block_header_map.insert(
                "l2_gas_price".to_string(),
                to_value(GasPricePerToken {
                    price_in_wei: 1_u8.into(),
                    price_in_fri: 1_u8.into(),
                })?,
            );
        }

[avi-starkware]

@avi-starkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @noaov1).

---

crates/blockifier_reexecution/src/state_reader/rpc_state_reader.rs line 257 at r1 (raw file):

Previously, AvivYossef-starkware wrote…

I tested it, and it is unnecessary when using rpc-v0.10, even for old blocks.

Are you sure the l2_gas_price is unnecessary for old blocks? Why was it added in the first place if that is the case?

[AvivYossef-starkware]

@AvivYossef-starkware made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avi-starkware and @noaov1).

---

crates/blockifier_reexecution/src/state_reader/rpc_state_reader.rs line 257 at r1 (raw file):

Previously, avi-starkware (Avi Cohen) wrote…

Are you sure the l2_gas_price is unnecessary for old blocks? Why was it added in the first place if that is the case?

If I remember correctly, we didnt know that newer rpc version would solve it.
Look at blockheader.json
It's an old block and it has the default l2_gas_price

[AvivYossef-starkware]

@AvivYossef-starkware resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noaov1).

[avi-starkware]

@avi-starkware made 1 comment.
Reviewable status: 1 of 3 files reviewed, all discussions resolved (waiting on @noaov1).

[AvivYossef-starkware]

@AvivYossef-starkware reviewed all commit messages.
Reviewable status: 1 of 3 files reviewed, all discussions resolved (waiting on @noaov1).

[AvivYossef-starkware]

@AvivYossef-starkware reviewed 2 files.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noaov1).