starknet_os_runner: aviv refactor the rpc state reader to compute the compiled class hash

[AvivYossef-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[AvivYossef-starkware]

• starknet_os_runner: aviv refactor the rpc state reader to compute the compiled class hash #11302 👈 (View in Graphite)
• starknet_os_runner: base block info #11295
• blockifier_reexecution: refactor get block header #11374
• apollo_gateway: add missing fields to block header #11373
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[avi-starkware]

@avi-starkware reviewed 2 files and all commit messages, and made 4 comments.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @AvivYossef-starkware and @noaov1).

---

crates/blockifier_reexecution/src/state_reader/rpc_state_reader.rs line 164 at r2 (raw file):

    /// Use the default implementation of get_compiled_class_hash_v2.
    /// Which compute the hash.

This doesn't mean much to people who don't have the context.
Why not keep this dockstring as it was?

Code quote:

    /// Use the default implementation of get_compiled_class_hash_v2.
    /// Which compute the hash.

---

crates/blockifier_reexecution/src/state_reader/rpc_state_reader.rs line 292 at r2 (raw file):

        let mut vc = VersionedConstants::get(&self.get_starknet_version()?)?.clone();
        // The rpc state reader does not support casm hash migration, which requires compiled class
        // hashes. .

Suggestion:

        // Casm hash migration is not supported. It requires compiled class hashes, and the RPC state reader does not have them.

---

crates/blockifier_reexecution/src/state_reader/rpc_state_reader.rs line 333 at r2 (raw file):

    /// Get the commitment state diff of the current block.
    /// Notice: we ignore migrated_compiled_classes.

Suggestion:

    /// Get the commitment state diff of the current block.
    /// Note: the commitment state diff does not include migrated_compiled_classes.

---

crates/blockifier_reexecution/src/state_reader/rpc_state_reader.rs line 164 at r2 (raw file):

    /// need to be migrated from v1 to v2 format.
    /// In reexecution we use a dummy value for both get_compiled_class_hash and
    /// get_compiled_class_hash_v2, to avoid the migration process.

Why is this no longer true?

Code quote:

    /// Returns a dummy compiled class hash for reexecution purposes.
    ///
    /// This method is required since v0.14.1 for checking if compiled class hashes
    /// need to be migrated from v1 to v2 format.
    /// In reexecution we use a dummy value for both get_compiled_class_hash and
    /// get_compiled_class_hash_v2, to avoid the migration process.

[AvivYossef-starkware]

@AvivYossef-starkware made 4 comments.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @avi-starkware and @noaov1).

---

crates/blockifier_reexecution/src/state_reader/rpc_state_reader.rs line 164 at r2 (raw file):

Previously, avi-starkware (Avi Cohen) wrote…

Why is this no longer true?

since now it is unimplemented for the get_compiled_class_hash
and returns the actual v2 hash

---

crates/blockifier_reexecution/src/state_reader/rpc_state_reader.rs line 164 at r2 (raw file):

Previously, avi-starkware (Avi Cohen) wrote…

This doesn't mean much to people who don't have the context.
Why not keep this dockstring as it was?

Since now it does not return the same value as the get compiled hash, which is unimplemented.
It just computes it

---

crates/blockifier_reexecution/src/state_reader/rpc_state_reader.rs line 292 at r2 (raw file):

        let mut vc = VersionedConstants::get(&self.get_starknet_version()?)?.clone();
        // The rpc state reader does not support casm hash migration, which requires compiled class
        // hashes. .

Done.

---

crates/blockifier_reexecution/src/state_reader/rpc_state_reader.rs line 333 at r2 (raw file):

    /// Get the commitment state diff of the current block.
    /// Notice: we ignore migrated_compiled_classes.

Done.

[avi-starkware]

@avi-starkware reviewed 3 files and all commit messages, made 2 comments, and resolved 3 discussions.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @noaov1).

---

crates/blockifier_reexecution/src/state_reader/rpc_state_reader.rs line 164 at r2 (raw file):

Previously, AvivYossef-starkware wrote…

Since now it does not return the same value as the get compiled hash, which is unimplemented.
It just computes it

Let's remove the docstring if that is the case
(the function does exactly what its name says it does)

[avi-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @noaov1).

[graphite-app]

Merge activity

• Jan 6, 3:14 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

[AvivYossef-starkware]

@AvivYossef-starkware reviewed 1 file and resolved 1 discussion.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @noaov1).

[AvivYossef-starkware]

@AvivYossef-starkware reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noaov1).

[AvivYossef-starkware]

@AvivYossef-starkware reviewed 1 file and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noaov1).