starknet_os_runner: classes provider using class manager

[AvivYossef-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[github-actions]

Artifacts upload workflows:

• Started at 2025-12-23T12:55:07Z
• Started at 2025-12-23T12:55:43Z
• Started at 2025-12-24T13:58:09Z
• Started at 2025-12-24T13:58:08Z
• Started at 2025-12-25T08:22:08Z
• Started at 2025-12-25T08:24:02Z
• Started at 2025-12-25T14:47:10Z
• Started at 2025-12-28T06:30:50Z
• Started at 2025-12-28T06:30:50Z
• Started at 2025-12-28T09:25:43Z
• Started at 2025-12-28T09:38:56Z
• Started at 2025-12-28T09:55:51Z
• Started at 2025-12-28T10:11:23Z
• Started at 2025-12-28T11:05:47Z

[AvivYossef-starkware]

• starknet_os_runner: aviv refactor the rpc state reader to compute the compiled class hash #11302
• starknet_os_runner: base block info #11295
• starknet_os_runner: fetch classes concurrent #11288
• starknet_os_runner: prev block hash #11188
• starknet_os_runner: virtual block input #11176
• starknet_os_runner: classes provider using class manager #11006 👈 (View in Graphite)
• blockifier: convert entry points #11005
• starknet_os_runner: run os #10941
• starknet_os_runner: build os input #10940
• starknet_os_runner: class provider #10939
• starknet_os_runner: share test utils #10934
• starknet_os_runner: storage proof provider trait #10891
• starknet_os_runner: rpc storage_proofs #10890
• starknet_patricia: from merkle node to preimage #10889
• starknet_os_runner: add executed_class_hashes to virtual block execution data #10932
• starknet_os_runner: virtual block executor #10930
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Yoni-Starkware]

@Yoni-Starkware made 1 comment.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware).

---

crates/starknet_os_runner/src/classes_provider.rs line 67 at r2 (raw file):

            }

            // Fallback to fetch.

Why not reuse the mechanism of StateReaderAndContractManager?
You get almost everything for free. The casm hash is cached, etc.

Code quote:

            // Fallback to fetch.

[AvivYossef-starkware]

@AvivYossef-starkware made 1 comment.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @Yoni-Starkware).

---

crates/starknet_os_runner/src/classes_provider.rs line 67 at r2 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Why not reuse the mechanism of StateReaderAndContractManager?
You get almost everything for free. The casm hash is cached, etc.

I have two problems witht that,

1. the RPC state reader returns a dummy compiled class hash
2. the RPC state reader compile to cam -> convert to contract_class v1 -> we need to convert to casm again

[AvivYossef-starkware]

@AvivYossef-starkware made 1 comment.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @Yoni-Starkware).

---

crates/starknet_os_runner/src/classes_provider.rs line 67 at r2 (raw file):

Previously, AvivYossef-starkware wrote…

I have two problems witht that,

1. the RPC state reader returns a dummy compiled class hash
2. the RPC state reader compile to cam -> convert to contract_class v1 -> we need to convert to casm again

Done

[Yoni-Starkware]

@Yoni-Starkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: 1 of 5 files reviewed, 2 unresolved discussions (waiting on @AvivYossef-starkware).

---

crates/starknet_os_runner/Cargo.toml line 10 at r5 (raw file):

[features]
cairo_native = ["blockifier/cairo_native"]

Is this necessary?

Code quote:

cairo_native = ["blockifier/cairo_native"]

[Yoni-Starkware]

@Yoni-Starkware made 3 comments and resolved 1 discussion.
Reviewable status: 1 of 5 files reviewed, 3 unresolved discussions (waiting on @AvivYossef-starkware).

---

crates/starknet_os_runner/Cargo.toml line 10 at r5 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Is this necessary?

Oh, nevermind

---

crates/starknet_os_runner/src/classes_provider.rs line 35 at r5 (raw file):

        for &class_hash in executed_class_hashes {
            let (compiled_class_hash, casm) = self.fetch_class(class_hash)?;
            compiled_classes.insert(compiled_class_hash, casm);

Add a TODO to parallelize this

Code quote:

        for &class_hash in executed_class_hashes {
            let (compiled_class_hash, casm) = self.fetch_class(class_hash)?;
            compiled_classes.insert(compiled_class_hash, casm);

---

crates/starknet_os_runner/src/classes_provider.rs line 40 at r5 (raw file):

    }

    /// Fetch class by class hash.

Suggestion:

    /// Fetches class by class hash.

[Yoni-Starkware]

@Yoni-Starkware made 2 comments.
Reviewable status: 1 of 5 files reviewed, 5 unresolved discussions (waiting on @AvivYossef-starkware).

---

crates/starknet_os_runner/src/classes_provider.rs line 74 at r5 (raw file):

        entry_points_by_type: (&class.entry_points_by_type).into(),
    }
}

And move this below all impl blocks

Suggestion:

/// Converts a `CompiledClassV1` to a `CasmContractClass` for OS execution.
/// Note: Some fields are not preserved in `CompiledClassV1` and are set to default values:
/// - `compiler_version`: Set to empty string
/// - `hints`: Set to empty (OS doesn't use them from this struct for Cairo 1 contracts)
/// - `pythonic_hints`: Set to None
fn compiled_class_v1_to_casm(class: &CompiledClassV1) -> CasmContractClass {
    // TODO(Aviv): Consider using dummy prime since it is not used in the OS.
    let prime = Felt::prime();

    let bytecode: Vec<BigUintAsHex> = class
        .program
        .iter_data()
        .map(|maybe_relocatable| match maybe_relocatable {
            MaybeRelocatable::Int(felt) => BigUintAsHex { value: felt.to_biguint() },
            _ => panic!("Expected all bytecode elements to be MaybeRelocatable::Int"),
        })
        .collect();

    CasmContractClass {
        prime,
        compiler_version: String::new(),
        bytecode,
        bytecode_segment_lengths: Some(class.bytecode_segment_felt_sizes().into()),
        hints: Vec::new(),
        pythonic_hints: None,
        entry_points_by_type: (&class.entry_points_by_type).into(),
    }
}

---

crates/starknet_os_runner/src/classes_provider.rs line 90 at r5 (raw file):

            RunnableCompiledClass::V1(compiled_class_v1) => {
                let casm = compiled_class_v1_to_casm(&compiled_class_v1);
                let compiled_class_hash = self.get_compiled_class_hash(class_hash)?;

I think get_compiled_class_hash_v2 is the one that is already cached in the state-reader-and-class-manager

Code quote:

self.get_compiled_class_hash

[AvivYossef-starkware]

@AvivYossef-starkware resolved 2 discussions.
Reviewable status: 1 of 5 files reviewed, 1 unresolved discussion (waiting on @Yoni-Starkware).

[Yoni-Starkware]

@Yoni-Starkware reviewed 1 file.
Reviewable status: 2 of 5 files reviewed, 3 unresolved discussions.

[AvivYossef-starkware]

@AvivYossef-starkware made 1 comment and resolved 1 discussion.
Reviewable status: 2 of 5 files reviewed, 2 unresolved discussions (waiting on @Yoni-Starkware).

---

crates/starknet_os_runner/src/classes_provider.rs line 90 at r5 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

I think get_compiled_class_hash_v2 is the one that is already cached in the state-reader-and-class-manager

right, notice that right now it return dummy value

[Yoni-Starkware]

@Yoni-Starkware reviewed 6 files and all commit messages, made 1 comment, and resolved 2 discussions.
Reviewable status: 6 of 7 files reviewed, all discussions resolved.

[Yoni-Starkware]

@Yoni-Starkware reviewed 3 files and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware).