Skip to content

Conversation

@AvivYossef-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@AvivYossef-starkware AvivYossef-starkware marked this pull request as ready for review December 28, 2025 07:10
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/starknet_os_runner_prev_block_hash branch 2 times, most recently from 2279380 to cf58304 Compare December 28, 2025 09:38
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/virtual_block_input branch 2 times, most recently from 5492d9e to 86c94d3 Compare December 28, 2025 09:55
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/starknet_os_runner_prev_block_hash branch from cf58304 to 68c9fc8 Compare December 28, 2025 09:55
@AvivYossef-starkware AvivYossef-starkware changed the base branch from aviv/virtual_block_input to graphite-base/11188 December 28, 2025 11:05
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/starknet_os_runner_prev_block_hash branch from 68c9fc8 to 52d0d1a Compare December 28, 2025 11:06
@AvivYossef-starkware AvivYossef-starkware changed the base branch from graphite-base/11188 to aviv/virtual_block_input December 28, 2025 11:06
@graphite-app graphite-app bot changed the base branch from aviv/virtual_block_input to graphite-base/11188 December 30, 2025 08:35
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/starknet_os_runner_prev_block_hash branch from 52d0d1a to 81322b4 Compare December 30, 2025 09:22
@AvivYossef-starkware AvivYossef-starkware changed the base branch from graphite-base/11188 to aviv/virtual_block_input December 30, 2025 09:22
Copy link
Collaborator

@avi-starkware avi-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avi-starkware reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware, @noaov1, and @Yoni-Starkware).


crates/starknet_os_runner/src/virtual_block_executor.rs line 30 at r1 (raw file):

/// A virtual block is a set of transactions executed together without block preprocessing,
/// useful for OS input generation and proving. This struct contains all the transaction execution
/// outputs, block context, and initial state reads needed for proof generation.

The class also contains the executed class hash and the prev_base_block_hash.
I think you can shorten it to "all the execution data needed for proof generation" to avoid this docstring going stale when the fields of this struct change in the future.

Code quote:

/// useful for OS input generation and proving. This struct contains all the transaction execution
/// outputs, block context, and initial state reads needed for proof generation.

Copy link
Collaborator

@avi-starkware avi-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware, @noaov1, and @Yoni-Starkware).

@AvivYossef-starkware AvivYossef-starkware changed the base branch from aviv/virtual_block_input to main December 30, 2025 12:33
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/starknet_os_runner_prev_block_hash branch from 81322b4 to fa22b9f Compare December 30, 2025 12:33
@graphite-app
Copy link

graphite-app bot commented Dec 30, 2025

Merge activity

  • Dec 30, 12:34 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

Copy link
Contributor Author

@AvivYossef-starkware AvivYossef-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AvivYossef-starkware resolved 1 discussion.
Reviewable status: 2 of 3 files reviewed, all discussions resolved (waiting on @avi-starkware, @noaov1, and @Yoni-Starkware).

Copy link
Contributor Author

@AvivYossef-starkware AvivYossef-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AvivYossef-starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @noaov1 and @Yoni-Starkware).

@AvivYossef-starkware AvivYossef-starkware added this pull request to the merge queue Dec 30, 2025
Merged via the queue into main with commit 1631026 Dec 30, 2025
13 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants