-
Notifications
You must be signed in to change notification settings - Fork 65
starknet_os_runner: prev block hash #11188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
starknet_os_runner: prev block hash #11188
Conversation
70e59f2 to
f395be8
Compare
2279380 to
cf58304
Compare
5492d9e to
86c94d3
Compare
cf58304 to
68c9fc8
Compare
86c94d3 to
4d2df7a
Compare
68c9fc8 to
52d0d1a
Compare
52d0d1a to
81322b4
Compare
4d2df7a to
8ef8bb3
Compare
avi-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@avi-starkware reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware, @noaov1, and @Yoni-Starkware).
crates/starknet_os_runner/src/virtual_block_executor.rs line 30 at r1 (raw file):
/// A virtual block is a set of transactions executed together without block preprocessing, /// useful for OS input generation and proving. This struct contains all the transaction execution /// outputs, block context, and initial state reads needed for proof generation.
The class also contains the executed class hash and the prev_base_block_hash.
I think you can shorten it to "all the execution data needed for proof generation" to avoid this docstring going stale when the fields of this struct change in the future.
Code quote:
/// useful for OS input generation and proving. This struct contains all the transaction execution
/// outputs, block context, and initial state reads needed for proof generation.
avi-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware, @noaov1, and @Yoni-Starkware).
81322b4 to
fa22b9f
Compare
Merge activity
|
fa22b9f to
9ff727e
Compare
AvivYossef-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AvivYossef-starkware resolved 1 discussion.
Reviewable status: 2 of 3 files reviewed, all discussions resolved (waiting on @avi-starkware, @noaov1, and @Yoni-Starkware).
AvivYossef-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AvivYossef-starkware reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @noaov1 and @Yoni-Starkware).

No description provided.