-
Notifications
You must be signed in to change notification settings - Fork 65
starknet_os_runner: rpc storage_proofs #10890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e3e1546 to
603639d
Compare
f7f312b to
8a16efd
Compare
603639d to
80579cc
Compare
80579cc to
3e1acb1
Compare
1401601 to
e8f7aa8
Compare
3e1acb1 to
f04d125
Compare
noaov1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@noaov1 made 1 comment.
Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on @avi-starkware and @AvivYossef-starkware).
crates/starknet_os_runner/src/storage_proofs.rs line 59 at r2 (raw file):
/// Extract query parameters from StateMaps. pub fn prepare_query(initial_reads: &StateMaps) -> RpcStorageProofsQuery { let class_hashes: Vec<Felt> = initial_reads.class_hashes.values().map(|ch| ch.0).collect();
What about library calls?
What about replcae class (if we will support it one day)?
Code quote:
let class_hashes: Vec<Felt> = initial_reads.class_hashes.values().map(|ch| ch.0).collect();
noaov1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@noaov1 reviewed 5 files and all commit messages, and made 2 comments.
Reviewable status: 5 of 6 files reviewed, 3 unresolved discussions (waiting on @avi-starkware and @AvivYossef-starkware).
crates/starknet_os_runner/src/lib.rs line 6 at r2 (raw file):
#[cfg(test)] mod virtual_block_executor_test; pub mod storage_proofs;
Suggestion:
pub mod errors;
pub mod storage_proofs;
pub mod virtual_block_executor;
#[cfg(test)]
mod virtual_block_executor_test;crates/starknet_os_runner/Cargo.toml line 15 at r2 (raw file):
starknet_api.workspace = true starknet_os.workspace = true starknet_patricia.workspace = true
Does it mean that we will need to publish those crates as well?
Code quote:
starknet_os.workspace = true
starknet_patricia.workspace = true
noaov1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@noaov1 made 1 comment.
Reviewable status: 5 of 6 files reviewed, 3 unresolved discussions (waiting on @avi-starkware and @AvivYossef-starkware).
crates/starknet_os_runner/src/storage_proofs.rs line 59 at r2 (raw file):
Previously, noaov1 (Noa Oved) wrote…
What about library calls?
What about replcae class (if we will support it one day)?
We may need to use the execution infos
e8f7aa8 to
356082d
Compare
f04d125 to
8d5c17a
Compare
AvivYossef-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AvivYossef-starkware made 3 comments and resolved 1 discussion.
Reviewable status: 5 of 6 files reviewed, 2 unresolved discussions (waiting on @avi-starkware and @noaov1).
crates/starknet_os_runner/Cargo.toml line 15 at r2 (raw file):
Previously, noaov1 (Noa Oved) wrote…
Does it mean that we will need to publish those crates as well?
yes
crates/starknet_os_runner/src/storage_proofs.rs line 59 at r2 (raw file):
Previously, noaov1 (Noa Oved) wrote…
What about library calls?
What about replcae class (if we will support it one day)?
Replace class causes state diff, one of the assumptions is that the tx doesn't create state diff.
About the library calls, you are right, I refactored it
crates/starknet_os_runner/src/lib.rs line 6 at r2 (raw file):
#[cfg(test)] mod virtual_block_executor_test; pub mod storage_proofs;
Done
356082d to
b71433d
Compare
8d5c17a to
34dabe7
Compare
34dabe7 to
b7bc6a3
Compare
b71433d to
add4651
Compare
b7bc6a3 to
f6e46a0
Compare
Merge activity
|
c107c8e to
ec0f1ec
Compare
ec0f1ec to
6f594cb
Compare
6f594cb to
1b5a2bb
Compare
meship-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@meship-starkware reviewed 6 files and all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @avi-starkware and @noaov1).
meship-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@meship-starkware made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @avi-starkware and @noaov1).
AvivYossef-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AvivYossef-starkware resolved 1 discussion and dismissed @noaov1 from a discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avi-starkware).
AvivYossef-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AvivYossef-starkware resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @avi-starkware).

No description provided.