Skip to content

Conversation

@AvivYossef-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator

@noaov1 noaov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noaov1 made 1 comment.
Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on @avi-starkware and @AvivYossef-starkware).


crates/starknet_os_runner/src/storage_proofs.rs line 59 at r2 (raw file):

    /// Extract query parameters from StateMaps.
    pub fn prepare_query(initial_reads: &StateMaps) -> RpcStorageProofsQuery {
        let class_hashes: Vec<Felt> = initial_reads.class_hashes.values().map(|ch| ch.0).collect();

What about library calls?
What about replcae class (if we will support it one day)?

Code quote:

        let class_hashes: Vec<Felt> = initial_reads.class_hashes.values().map(|ch| ch.0).collect();

Copy link
Collaborator

@noaov1 noaov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noaov1 reviewed 5 files and all commit messages, and made 2 comments.
Reviewable status: 5 of 6 files reviewed, 3 unresolved discussions (waiting on @avi-starkware and @AvivYossef-starkware).


crates/starknet_os_runner/src/lib.rs line 6 at r2 (raw file):

#[cfg(test)]
mod virtual_block_executor_test;
pub mod storage_proofs;

Suggestion:

pub mod errors;
pub mod storage_proofs;
pub mod virtual_block_executor;

#[cfg(test)]
mod virtual_block_executor_test;

crates/starknet_os_runner/Cargo.toml line 15 at r2 (raw file):

starknet_api.workspace = true
starknet_os.workspace = true
starknet_patricia.workspace = true

Does it mean that we will need to publish those crates as well?

Code quote:

starknet_os.workspace = true
starknet_patricia.workspace = true

@graphite-app graphite-app bot changed the base branch from aviv/from_merkle_node_to_preimage to graphite-base/10890 December 21, 2025 09:49
noaov1
noaov1 previously requested changes Dec 21, 2025
Copy link
Collaborator

@noaov1 noaov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noaov1 made 1 comment.
Reviewable status: 5 of 6 files reviewed, 3 unresolved discussions (waiting on @avi-starkware and @AvivYossef-starkware).


crates/starknet_os_runner/src/storage_proofs.rs line 59 at r2 (raw file):

Previously, noaov1 (Noa Oved) wrote…

What about library calls?
What about replcae class (if we will support it one day)?

We may need to use the execution infos

Copy link
Contributor Author

@AvivYossef-starkware AvivYossef-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AvivYossef-starkware made 3 comments and resolved 1 discussion.
Reviewable status: 5 of 6 files reviewed, 2 unresolved discussions (waiting on @avi-starkware and @noaov1).


crates/starknet_os_runner/Cargo.toml line 15 at r2 (raw file):

Previously, noaov1 (Noa Oved) wrote…

Does it mean that we will need to publish those crates as well?

yes


crates/starknet_os_runner/src/storage_proofs.rs line 59 at r2 (raw file):

Previously, noaov1 (Noa Oved) wrote…

What about library calls?
What about replcae class (if we will support it one day)?

Replace class causes state diff, one of the assumptions is that the tx doesn't create state diff.
About the library calls, you are right, I refactored it


crates/starknet_os_runner/src/lib.rs line 6 at r2 (raw file):

#[cfg(test)]
mod virtual_block_executor_test;
pub mod storage_proofs;

Done

@AvivYossef-starkware AvivYossef-starkware changed the base branch from graphite-base/10890 to aviv/from_merkle_node_to_preimage December 21, 2025 12:25
@AvivYossef-starkware AvivYossef-starkware changed the title straknet_os_runner: rpc storage_proofs starknet_os_runner: rpc storage_proofs Dec 21, 2025
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/from_merkle_node_to_preimage branch from 356082d to b71433d Compare December 23, 2025 07:23
@graphite-app graphite-app bot changed the base branch from aviv/from_merkle_node_to_preimage to graphite-base/10890 December 23, 2025 08:23
@AvivYossef-starkware AvivYossef-starkware changed the base branch from graphite-base/10890 to aviv/from_merkle_node_to_preimage December 23, 2025 08:41
@AvivYossef-starkware AvivYossef-starkware changed the base branch from aviv/from_merkle_node_to_preimage to main December 23, 2025 09:03
@graphite-app
Copy link

graphite-app bot commented Dec 23, 2025

Merge activity

  • Dec 23, 9:04 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

Copy link
Collaborator

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meship-starkware reviewed 6 files and all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @avi-starkware and @noaov1).

Copy link
Collaborator

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@meship-starkware made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @avi-starkware and @noaov1).

Copy link
Contributor Author

@AvivYossef-starkware AvivYossef-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AvivYossef-starkware resolved 1 discussion and dismissed @noaov1 from a discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avi-starkware).

Copy link
Contributor Author

@AvivYossef-starkware AvivYossef-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AvivYossef-starkware resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @avi-starkware).

@AvivYossef-starkware AvivYossef-starkware added this pull request to the merge queue Dec 24, 2025
Merged via the queue into main with commit 85fb990 Dec 24, 2025
27 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants