starknet_os: move commitment info

[AvivYossef-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[AvivYossef-starkware]

• starknet_os_runner: storage proof provider trait #10891
• starknet_os_runner: rpc storage_proofs #10890
• starknet_patricia: from merkle node to preimage #10889
• starknet_os: move commitment info #10877 👈 (View in Graphite)
• starknet_os_runner: test virtual block executor #10905
• starknet_os_runner: virtual block executor  #10849 : 1 other dependent PR (#10866 )
• blockifier_reexecution: split execute tx logic #10844 : 1 other dependent PR (#10855 )
• starknet_os_runner: initialize the crate #10888
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Yoni-Starkware]

@Yoni-Starkware made 1 comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @avi-starkware, @AvivYossef-starkware, and @noaov1).

---

crates/starknet_os/src/io/os_input.rs line 46 at r1 (raw file):

/// Contains all commitment information for a block's state trees.
pub struct CommitmentInfos {

Now that it's here, add State since there are other commitments in block.
Please add a TODO to use this struct in OsBlockInput.

Suggestion:

/// Contains all commitment information for a block's state trees.
pub struct StateCommitmentInfos {

[AvivYossef-starkware]

@AvivYossef-starkware made 1 comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @avi-starkware, @noaov1, and @Yoni-Starkware).

---

crates/starknet_os/src/io/os_input.rs line 46 at r1 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Now that it's here, add State since there are other commitments in block.
Please add a TODO to use this struct in OsBlockInput.

Done.

[meship-starkware]

@meship-starkware reviewed 2 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avi-starkware, @noaov1, and @Yoni-Starkware).

[Yoni-Starkware]

@Yoni-Starkware reviewed 2 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avi-starkware and @noaov1).

[AvivYossef-starkware]

@AvivYossef-starkware reviewed 2 files and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avi-starkware and @noaov1).