starknet_patricia: from merkle node to preimage

[AvivYossef-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[AvivYossef-starkware]

• starknet_os_runner: aviv refactor the rpc state reader to compute the compiled class hash #11302
• starknet_os_runner: base block info #11295
• starknet_os_runner: fetch classes concurrent #11288
• starknet_os_runner: prev block hash #11188
• starknet_os_runner: virtual block input #11176
• starknet_os_runner: classes provider using class manager #11006
• blockifier: convert entry points #11005
• starknet_os_runner: run os #10941
• starknet_os_runner: build os input #10940
• starknet_os_runner: class provider #10939
• starknet_os_runner: share test utils #10934
• starknet_os_runner: storage proof provider trait #10891
• starknet_os_runner: rpc storage_proofs #10890
• starknet_patricia: from merkle node to preimage #10889 👈 (View in Graphite)
• starknet_os_runner: add executed_class_hashes to virtual block execution data #10932
• starknet_os_runner: virtual block executor #10930
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Artifacts upload workflows:

• Started at 2025-12-17T14:57:18Z
• Started at 2025-12-18T13:46:20Z
• Started at 2025-12-18T14:22:02Z
• Started at 2025-12-18T14:30:19Z
• Started at 2025-12-21T07:43:11Z
• Started at 2025-12-18T14:30:19Z
• Started at 2025-12-21T12:25:02Z
• Started at 2025-12-21T12:25:14Z
• Started at 2025-12-21T12:25:02Z
• Started at 2025-12-23T07:23:50Z
• Started at 2025-12-23T07:23:51Z
• Started at 2025-12-23T07:45:03Z
• Started at 2025-12-23T08:23:29Z
• Started at 2025-12-23T08:24:01Z
• Started at 2025-12-23T08:41:05Z

[noaov1]

@noaov1 reviewed 5 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @avi-starkware and @AvivYossef-starkware).

---

crates/starknet_patricia/src/patricia_merkle_tree/node_data/inner_node_tests.rs line 38 at r1 (raw file):

#[case(Felt::ZERO, Felt::ZERO)]
#[case(Felt::from(0x1234_u128), Felt::from(0xABCD_u128))]
fn test_preimage_from_binary_merkle_node(#[case] left: Felt, #[case] right: Felt) {

What exactly do we test here?

Code quote:

fn test_preimage_from_binary_merkle_node(#[case] left: Felt, #[case] right: Felt) {

---

crates/starknet_patricia/src/patricia_merkle_tree/node_data/inner_node.rs line 242 at r1 (raw file):

}

impl From<&MerkleNode> for Preimage {

Why is it needed?

Code quote:

impl From<&MerkleNode> for Preimage {

[graphite-app]

Merge activity

• Dec 21, 9:49 AM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
• Dec 21, 9:49 AM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
• Dec 23, 8:24 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

[AvivYossef-starkware]

@AvivYossef-starkware made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @avi-starkware and @noaov1).

---

crates/starknet_patricia/src/patricia_merkle_tree/node_data/inner_node.rs line 242 at r1 (raw file):

Previously, noaov1 (Noa Oved) wrote…

Why is it needed?

I use it in the next PR

---

crates/starknet_patricia/src/patricia_merkle_tree/node_data/inner_node_tests.rs line 38 at r1 (raw file):

Previously, noaov1 (Noa Oved) wrote…

What exactly do we test here?

That the conversion works as expected
It was more of a sanity check for me.
I can delete it if you'd like

[meship-starkware]

@meship-starkware reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @avi-starkware, @AvivYossef-starkware, and @noaov1).

---

crates/starknet_patricia/src/patricia_merkle_tree/node_data/inner_node_tests.rs line 38 at r1 (raw file):

Previously, AvivYossef-starkware wrote…

That the conversion works as expected
It was more of a sanity check for me.
I can delete it if you'd like

I am in favor of deleting them. I don't think they test anything that we won't get from using the function

[AvivYossef-starkware]

@AvivYossef-starkware made 1 comment and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avi-starkware and @meship-starkware).

---

crates/starknet_patricia/src/patricia_merkle_tree/node_data/inner_node_tests.rs line 38 at r1 (raw file):

Previously, meship-starkware (Meshi Peled) wrote…

I am in favor of deleting them. I don't think they test anything that we won't get from using the function

Done.

[meship-starkware]

@meship-starkware reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avi-starkware).

[meship-starkware]

@meship-starkware made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avi-starkware).