Skip to content

Conversation

@AvivYossef-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yoni-Starkware made 1 comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @noaov1).


crates/starknet_os_runner/src/virtual_block_executor.rs line 179 at r1 (raw file):

/// without block preprocessing. Validation and fee charging are always skipped,
/// making it suitable for simulation and OS input generation.
impl VirtualBlockExecutor for RpcStateReader {

It's a bit weird. Can you please restore the dedicated struct for execution?

Code quote:

impl VirtualBlockExecutor for RpcStateReader {

Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yoni-Starkware reviewed 1 file.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @noaov1).

Copy link
Contributor Author

@AvivYossef-starkware AvivYossef-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AvivYossef-starkware made 1 comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @noaov1 and @Yoni-Starkware).


crates/starknet_os_runner/src/virtual_block_executor.rs line 179 at r1 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

It's a bit weird. Can you please restore the dedicated struct for execution?

Done.

Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Yoni-Starkware reviewed 2 files and all commit messages, made 2 comments, and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @noaov1).


crates/starknet_os_runner/src/virtual_block_executor.rs line 55 at r2 (raw file):

///
/// ```text
/// let executor = RpcStateReader::new_with_config_from_url(

Update docs

Code quote:

 RpcStateReader::new_with_config_from_url(

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/refactor_virtual_block_executor branch from a5acdac to 12b1c26 Compare December 23, 2025 07:23
Copy link
Contributor Author

@AvivYossef-starkware AvivYossef-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AvivYossef-starkware reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @noaov1).

@AvivYossef-starkware AvivYossef-starkware added this pull request to the merge queue Dec 23, 2025
Merged via the queue into main with commit 9b72253 Dec 23, 2025
13 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants