-
Notifications
You must be signed in to change notification settings - Fork 65
starknet_os_runner: virtual block executor #10930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
starknet_os_runner: virtual block executor #10930
Conversation
81c2517 to
1b993b5
Compare
Yoni-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Yoni-Starkware made 1 comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @noaov1).
crates/starknet_os_runner/src/virtual_block_executor.rs line 179 at r1 (raw file):
/// without block preprocessing. Validation and fee charging are always skipped, /// making it suitable for simulation and OS input generation. impl VirtualBlockExecutor for RpcStateReader {
It's a bit weird. Can you please restore the dedicated struct for execution?
Code quote:
impl VirtualBlockExecutor for RpcStateReader {
Yoni-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Yoni-Starkware reviewed 1 file.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @noaov1).
1b993b5 to
a5acdac
Compare
AvivYossef-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AvivYossef-starkware made 1 comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @noaov1 and @Yoni-Starkware).
crates/starknet_os_runner/src/virtual_block_executor.rs line 179 at r1 (raw file):
Previously, Yoni-Starkware (Yoni) wrote…
It's a bit weird. Can you please restore the dedicated struct for execution?
Done.
Yoni-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Yoni-Starkware reviewed 2 files and all commit messages, made 2 comments, and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @noaov1).
crates/starknet_os_runner/src/virtual_block_executor.rs line 55 at r2 (raw file):
/// /// ```text /// let executor = RpcStateReader::new_with_config_from_url(
Update docs
Code quote:
RpcStateReader::new_with_config_from_url(a5acdac to
12b1c26
Compare
AvivYossef-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AvivYossef-starkware reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @noaov1).

No description provided.