starknet_os_runner: build os input

[AvivYossef-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[AvivYossef-starkware]

• starknet_os_runner: aviv refactor the rpc state reader to compute the compiled class hash #11302
• starknet_os_runner: base block info #11295
• starknet_os_runner: fetch classes concurrent #11288
• starknet_os_runner: prev block hash #11188
• starknet_os_runner: virtual block input #11176
• starknet_os_runner: classes provider using class manager #11006
• blockifier: convert entry points #11005
• starknet_os_runner: run os #10941
• starknet_os_runner: build os input #10940 👈 (View in Graphite)
• starknet_os_runner: class provider #10939
• starknet_os_runner: share test utils #10934
• starknet_os_runner: storage proof provider trait #10891
• starknet_os_runner: rpc storage_proofs #10890
• starknet_patricia: from merkle node to preimage #10889
• starknet_os_runner: add executed_class_hashes to virtual block execution data #10932
• starknet_os_runner: virtual block executor #10930
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[meship-starkware]

@meship-starkware partially reviewed 7 files and made 1 comment.
Reviewable status: 4 of 7 files reviewed, all discussions resolved (waiting on @avi-starkware and @noaov1).

[Yoni-Starkware]

@Yoni-Starkware reviewed 3 files and made 4 comments.
Reviewable status: 5 of 7 files reviewed, 4 unresolved discussions (waiting on @avi-starkware, @AvivYossef-starkware, @meship-starkware, and @noaov1).

---

crates/starknet_os_runner/src/runner.rs line 31 at r3 (raw file):

    V: VirtualBlockExecutor,
{
    pub fn new(classes_provider: C, storage_proofs_provider: S, virtual_block_executor: V) -> Self {

Note: I hope to use this code for general block proofs, not just virtual ones. Not for our first milestone, but keep in mind.

Code quote:

virtual_block_executor

---

crates/starknet_os_runner/src/runner.rs line 35 at r3 (raw file):

    }

    /// Creates OS input from execution data and storage proofs.

Suggestion:

    /// Creates the OS input hint required to run the given transactions virtually on top of the given block number.

---

crates/starknet_os_runner/src/runner.rs line 42 at r3 (raw file):

        txs: Vec<(InvokeTransaction, TransactionHash)>,
    ) -> Result<StarknetOsInput, RunnerError> {
        // 1. Execute virtual block and get execution data.

Remove the numbers from the documentation (annoying to maintain)

Code quote:

 // 1.

---

crates/starknet_os_runner/src/runner.rs line 94 at r3 (raw file):

            // We assume that no classes are migrated.
            class_hashes_to_migrate: HashMap::new(),
            // Stored block hash buffer skipped for now.

Suggestion:

// Virtual OS does not update the block hash mapping

[AvivYossef-starkware]

@AvivYossef-starkware made 2 comments and resolved 2 discussions.
Reviewable status: 4 of 7 files reviewed, 2 unresolved discussions (waiting on @avi-starkware, @meship-starkware, @noaov1, and @Yoni-Starkware).

---

crates/starknet_os_runner/src/runner.rs line 31 at r3 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Note: I hope to use this code for general block proofs, not just virtual ones. Not for our first milestone, but keep in mind.

The differences are
preprocess,
finalize,
writing to state
and new block hash right?

---

crates/starknet_os_runner/src/runner.rs line 35 at r3 (raw file):

    }

    /// Creates OS input from execution data and storage proofs.

Done.

[Yoni-Starkware]

@Yoni-Starkware reviewed 6 files and all commit messages, made 2 comments, and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @avi-starkware, @AvivYossef-starkware, and @noaov1).

---

crates/starknet_os_runner/src/runner.rs line 31 at r3 (raw file):

Previously, AvivYossef-starkware wrote…

The differences are
preprocess,
finalize,
writing to state
and new block hash right?

Yes

[graphite-app]

Merge activity

• Dec 25, 3:47 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

[AvivYossef-starkware]

@AvivYossef-starkware resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avi-starkware and @noaov1).