Skip to content

Conversation

@yoavGrs
Copy link
Contributor

@yoavGrs yoavGrs commented Jan 6, 2026

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

yoavGrs commented Jan 6, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@yoavGrs yoavGrs self-assigned this Jan 6, 2026
@yoavGrs yoavGrs marked this pull request as ready for review January 6, 2026 09:17
@yoavGrs yoavGrs force-pushed the yoav/apollo_batcher/commitment_manager_types/use_committer_types branch 2 times, most recently from eb2af58 to fd812d6 Compare January 6, 2026 09:53
@yoavGrs yoavGrs requested a review from amosStarkware January 6, 2026 09:54
Copy link
Contributor Author

@yoavGrs yoavGrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoavGrs made 1 comment.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @amosStarkware).


crates/apollo_batcher/src/batcher.rs line 1182 at r1 (raw file):

        commit_response_result: CommitterClientResult<CommitBlockResponse>,
    ) -> BatcherResult<()> {
        // TODO: Handle commit block error.

@amosStarkware
Can I assign you to this TODO?

Code quote:

// TODO: Handle commit block error.

@yoavGrs yoavGrs force-pushed the yoav/apollo_batcher/commitment_manager_types/use_committer_types branch from fd812d6 to 2e05557 Compare January 6, 2026 12:29
@yoavGrs yoavGrs closed this Jan 8, 2026
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants