apollo_batcher: perform commitment tasks

[yoavGrs]

No description provided.

[reviewable-StarkWare]

This change is 

[yoavGrs]

• apollo_batcher: add revert task #11451 : 2 dependent PRs (#11496 , #11516 )
• apollo_batcher: define custom input task type #11595
• apollo_batcher: wait for revert result #11484
• apollo_batcher: perform commitment tasks #11442 👈 (View in Graphite)
• main-v0.14.1-committer

This stack of pull requests is managed by Graphite. Learn more about stacking.

[amosStarkware]

@amosStarkware reviewed 1 file and all commit messages, and made 4 comments.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @yoavGrs).

---

crates/apollo_batcher/src/commitment_manager/state_committer.rs line 49 at r2 (raw file):

impl StateCommitter {
    /// Repeatedly performs any task in the channel.

Suggestion:

/// Performs the tasks in the channel. Retries at recoverable errors.

---

crates/apollo_batcher/src/commitment_manager/state_committer.rs line 50 at r2 (raw file):

impl StateCommitter {
    /// Repeatedly performs any task in the channel.
    pub(crate) async fn perform_commitment_tasks(

the original name was before we decided to add revert tasks. please also rename perform_commitment_task.
you can also add a TODO on me if it's a lot of work

Suggestion:

perform_tasks

---

crates/apollo_batcher/src/commitment_manager/state_committer.rs line 58 at r2 (raw file):

            let output = perform_commitment_task(request, &committer_client).await;
            // TODO(Yoav): wait for task channel by config.
            results_sender.send(output).await.unwrap();

I don't think we need a config here:
the tasks channel may grow very large if the committer is lagging behind the batcher.
but the results channel shouldn't grow very large. I'll keep this discussion open in case Dori thinks otherwise.
please change to try_send, match on errors (for more descriptive panic messages), and log when a result is added. similar to this

Suggestion:

            // TODO(Yoav): wait for task channel by config.
            results_sender.try_send(output).await.unwrap();

---

crates/apollo_batcher/src/commitment_manager/state_committer.rs line 107 at r2 (raw file):

/// Panics on unrecoverable errors.
async fn handle_task_error(error: CommitterClientError) {

is this more descriptive?

Suggestion:

log_errors_and_maybe_panic

[yoavGrs]

@yoavGrs made 4 comments.
Reviewable status: 0 of 1 files reviewed, 4 unresolved discussions (waiting on @amosStarkware).

---

crates/apollo_batcher/src/commitment_manager/state_committer.rs line 50 at r2 (raw file):

Previously, amosStarkware wrote…

the original name was before we decided to add revert tasks. please also rename perform_commitment_task.
you can also add a TODO on me if it's a lot of work

Done.

---

crates/apollo_batcher/src/commitment_manager/state_committer.rs line 58 at r2 (raw file):

Previously, amosStarkware wrote…

I don't think we need a config here:
the tasks channel may grow very large if the committer is lagging behind the batcher.
but the results channel shouldn't grow very large. I'll keep this discussion open in case Dori thinks otherwise.
please change to try_send, match on errors (for more descriptive panic messages), and log when a result is added. similar to this

Done.

---

crates/apollo_batcher/src/commitment_manager/state_committer.rs line 107 at r2 (raw file):

Previously, amosStarkware wrote…

is this more descriptive?

Done.

---

crates/apollo_batcher/src/commitment_manager/state_committer.rs line 49 at r2 (raw file):

impl StateCommitter {
    /// Repeatedly performs any task in the channel.

Done.

[dorimedini-starkware]

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @amosStarkware).

[amosStarkware]

@amosStarkware reviewed 1 file and all commit messages, made 1 comment, and resolved 4 discussions.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yoavGrs).

---

crates/apollo_batcher/src/commitment_manager/state_committer.rs line 67 at r3 (raw file):

                }
                Err(TrySendError::Full(_)) => panic!("Results channel is full."),
                Err(err) => panic!("Failed to send results. error: {err}"),

please add the results height to the error messages

Code quote:

                Err(TrySendError::Full(_)) => panic!("Results channel is full."),
                Err(err) => panic!("Failed to send results. error: {err}"),

[amosStarkware]

@amosStarkware made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @yoavGrs).

---

-- commits line 2 at r3:
Also - please add a unit test.
Can also add a TODO, if you're short on time

Code quote:

- 38f59ce: apollo_batcher: perform commitment tasks

[amosStarkware]

@amosStarkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dorimedini-starkware).

---

crates/apollo_batcher/src/commitment_manager/state_committer.rs line 122 at r9 (raw file):

Previously, dorimedini-starkware wrote…

still relevant?

Maybe change to:
// TODO(Amos): If the task performer panics, the Batcher will panic when it attempts to add tasks to the commitment manager. In this case, print an informative message.

[github-actions]

Artifacts upload workflows:

• Started at 2026-01-13T14:14:38Z

[dorimedini-starkware]

@dorimedini-starkware reviewed 6 files and all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @amosStarkware).

[dorimedini-starkware]

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @amosStarkware).

[dorimedini-starkware]

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @amosStarkware).

[amosStarkware]

@amosStarkware reviewed 7 files and all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @yoavGrs).

[dorimedini-starkware]

@dorimedini-starkware reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @amosStarkware).

---

crates/apollo_batcher/src/batcher.rs line 1162 at r16 (raw file):

        for commitment_task_output in commitment_results.into_iter() {
            let height = commitment_task_output.height;
            info!("Writing commitment results to storage for height {}.", height);

non-blocking

Suggestion:

info!("Writing commitment results to storage for height {height}.");

[dorimedini-starkware]

@dorimedini-starkware reviewed 3 files and all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @amosStarkware).