apollo_batcher: commitment manager output uses apollo committer types

[yoavGrs]

No description provided.

[reviewable-StarkWare]

This change is 

[yoavGrs]

• apollo_batcher: add revert task #11451 : 2 dependent PRs (#11496 , #11516 )
• apollo_batcher: wait for revert result #11484
• apollo_batcher: perform commitment tasks #11442
• apollo_batcher: commitment manager input uses apollo committer types #11483
• apollo_batcher: commitment manager output uses apollo committer types #11482 👈 (View in Graphite)
• main-v0.14.1-committer

This stack of pull requests is managed by Graphite. Learn more about stacking.

[amosStarkware]

@amosStarkware reviewed 6 files and all commit messages, and made 3 comments.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @yoavGrs).

---

crates/apollo_batcher/src/commitment_manager/commitment_manager_impl.rs line 269 at r1 (raw file):

    pub(crate) fn final_commitment_output<R: BatcherStorageReader + ?Sized>(
        storage_reader: Arc<R>,
        CommitmentTaskOutput { response: CommitBlockResponse { state_root: global_root }, height }: CommitmentTaskOutput,

can you add a TODO to rename state_root to global_root?

Code quote:

CommitmentTaskOutput { response: CommitBlockResponse { state_root: global_root }, height }: CommitmentTaskOutput,

---

crates/apollo_batcher/src/commitment_manager/types.rs line 30 at r1 (raw file):

pub type CommitmentTaskResult = CommitterClientResult<CommitmentTaskOutput>;
pub type RevertTaskResult = CommitterClientResult<RevertTaskOutput>;

I don't think the state committer should ever return an error - it should either panic or return the result.

Code quote:

pub type CommitmentTaskResult = CommitterClientResult<CommitmentTaskOutput>;
pub type RevertTaskResult = CommitterClientResult<RevertTaskOutput>;

---

crates/apollo_batcher/src/commitment_manager/types.rs line 42 at r1 (raw file):

        match self {
            Self::Commit(commitment_task_result) => commitment_task_result,
            Self::Revert(_) => panic!("Get revert result at unwrapping commitment."),

Suggestion:

Got revert result at unwrapping commitment.

[yoavGrs]

@yoavGrs made 3 comments.
Reviewable status: 0 of 7 files reviewed, 3 unresolved discussions (waiting on @amosStarkware and @yoavGrs).

---

crates/apollo_batcher/src/commitment_manager/commitment_manager_impl.rs line 269 at r1 (raw file):

Previously, amosStarkware wrote…

can you add a TODO to rename state_root to global_root?

Done.

---

crates/apollo_batcher/src/commitment_manager/types.rs line 30 at r1 (raw file):

Previously, amosStarkware wrote…

I don't think the state committer should ever return an error - it should either panic or return the result.

Removed.

---

crates/apollo_batcher/src/commitment_manager/types.rs line 42 at r1 (raw file):

        match self {
            Self::Commit(commitment_task_result) => commitment_task_result,
            Self::Revert(_) => panic!("Get revert result at unwrapping commitment."),

Done.

[amosStarkware]

@amosStarkware reviewed 7 files and all commit messages, and resolved 3 discussions.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @yoavGrs).

[dorimedini-starkware]

@dorimedini-starkware reviewed 7 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yoavGrs).

---

crates/apollo_batcher/src/commitment_manager/types.rs line 38 at r3 (raw file):

        match self {
            Self::Commit(commitment_task_output) => commitment_task_output,
            Self::Revert(_) => panic!("Got revert output."),

Suggestion:

panic!("Got revert output: {self:?}."),

[yoavGrs]

@yoavGrs made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware).

---

crates/apollo_batcher/src/commitment_manager/types.rs line 38 at r3 (raw file):

        match self {
            Self::Commit(commitment_task_output) => commitment_task_output,
            Self::Revert(_) => panic!("Got revert output."),

Done.

[dorimedini-starkware]

@dorimedini-starkware reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @yoavGrs).