Skip to content

Conversation

@Yoni-Starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor

@AvivYossef-starkware AvivYossef-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AvivYossef-starkware reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @noaov1).


crates/starknet_os/src/io/virtual_os_output.rs line 41 at r1 (raw file):

        if iter.next().is_some() {
            return Err(OsOutputError::OutputNotExhausted);
        }

Suggestion:

        // Verify that we have consumed all output.
        if iter.next().is_some() {
            return Err(OsOutputError::OutputNotExhausted);
        }

@Yoni-Starkware Yoni-Starkware force-pushed the yoni/starknet_os/ensure-output-iter-is-done branch from 8aa4a76 to 3272544 Compare January 7, 2026 07:38
Copy link
Collaborator Author

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yoni-Starkware reviewed 2 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @noaov1).

@Yoni-Starkware Yoni-Starkware added this pull request to the merge queue Jan 7, 2026
Merged via the queue into main with commit 0248cd2 Jan 7, 2026
14 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants