Skip to content

starknet_os: make sure the virtual output iterator is fully consumed #11469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yoni-Starkware merged 1 commit into from
Jan 7, 2026
Merged

starknet_os: make sure the virtual output iterator is fully consumed #11469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions crates/starknet_os/src/io/os_output.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@ pub enum OsOutputError {
InvalidOsOutputField { value_name: String, val: Felt, message: String },
#[error("Failed to convert to FullOsOutput. State diff variant is of a different type")]
ConvertToFullOutput,
#[error("Output iterator not exhausted.")]
OutputNotExhausted,
}

pub(crate) fn wrap_missing<T>(val: Option<T>, val_name: &str) -> Result<T, OsOutputError> {
Expand Down
5 changes: 5 additions & 0 deletions crates/starknet_os/src/io/virtual_os_output.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,11 @@ impl VirtualOsOutput {
let starknet_os_config_hash = wrap_missing(iter.next(), "starknet_os_config_hash")?;
let messages_to_l1 = parse_messages_to_l1(&mut iter)?;

// Verify that we have consumed all output.
if iter.next().is_some() {
return Err(OsOutputError::OutputNotExhausted);
}

Ok(Self {
version,
base_block_number,
Expand Down
Loading