apollo_gateway_config: create proof archive writer config

[einat-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[einat-starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• apollo_gateway: create GCS client and write proof to GCS #11497
• apollo_gateway: add large storage writer #11362
• apollo_gateway_config: create proof archive writer config #11478 👈 (View in Graphite)
• apollo_gateway: create large storage writer trait #11361
• apollo_gateway: use proof manager #11141 : 2 other dependent PRs (#11147 , #11471 )
• apollo_batcher: delete proof validator and move proof verification to transaction converter #11421 : 1 other dependent PR (#11157 )
• apollo_proof_manager: add proof manager client to the transaction converter #11044
• apollo_node: integrate proof manager server #11043
• apollo_node: integrate proof manager client into node #11042
• apollo_proof_manager: add metrics file #11041
• apollo_proof_manager: component request handler #11040
• apollo_proof_manager: implement component starter #11039
• apollo_proof_manager_types: create proof manager client #10965
• apollo_proof_manager: calculate hash within the proof storage #11382
• apollo_proof_manager: enable proof manager and add to deployments #11274
• apollo_proof_manager: add proof manager to node config and components #10956
• apollo_node_config: add proof manager config to node config #11242
• apollo_proof_manager: create proof manager #10943
• apollo_proof_manager: test fs proof storage #10902
• apollo_proof_manager: impl ProofStorage #10901
• apollo_proof_manager: read/write proof from file methods #10899
• apollo_proof_manager: add fs directory methods #10862
• apollo_proof_manager: add ProofStorage trait #10798
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[meship-starkware]

@meship-starkware reviewed 9 files and all commit messages, and made 4 comments.
Reviewable status: 9 of 10 files reviewed, 4 unresolved discussions (waiting on @avivg-starkware, @einat-starkware, and @noaov1).

---

crates/apollo_deployments/resources/app_configs/replacer_proof_manager_config.json line 2 at r1 (raw file):

{
    "proof_manager_config.persistent_root": "/data/proofs"

Revert

Code quote:

    "proof_manager_config.persistent_root": "/data/proofs"

---

crates/apollo_gateway/src/gateway.rs line 244 at r1 (raw file):

    let stateless_tx_validator = Arc::new(StatelessTransactionValidator {
        config: config.stateless_tx_validator_config.clone(),
    });

Could you revert here as well?

Code quote:

 });

---

crates/apollo_deployments/src/test_utils.rs line 58 at r1 (raw file):

            ],
            consensus_manager_config_network_config_secret_key: None,
            gateway_config_proof_archive_writer_config_bucket_name: "arbitrary_bucket_name"

Shouldn't we give it a more indicative name?

Code quote:

gateway_config_proof_archive_writer_config_bucket_name: "arbitrary_bucket_name"

---

crates/apollo_gateway_config/src/config.rs line 306 at r1 (raw file):

#[derive(Clone, Debug, Serialize, Deserialize, Validate, PartialEq)]
pub struct ProofArchiveWriterConfig {
    pub bucket_name: Sensitive<String>,

Why do we need the sensitive here?

Code quote:

 pub bucket_name: Sensitive<String>,