apollo_gateway: create large storage writer trait

[einat-starkware]

No description provided.

[einat-starkware]

• apollo_integration_tests: add txs with proof #11729
• apollo_transaction_converter: use proof manager to convert between transactions #11707
• apollo_transaction_converter: move transaction converter to its own crate #11705
• apollo_proof_manager: log verify and store times #11471
• apollo_gateway: only set proofs if they have passed tx validation in gateway #11703
• apollo_gateway: set the proof when adding a transaction #11638
• apollo_gateway: create GCS client and write proof to GCS #11497
• apollo_gateway: add large storage writer #11362
• apollo_gateway_config: create proof archive writer config #11478
• apollo_gateway: create large storage writer trait #11361 👈 (View in Graphite)
• apollo_gateway: use proof manager #11141 : 1 other dependent PR (#11147 )
• apollo_batcher: delete proof validator and move proof verification to transaction converter #11421 : 1 other dependent PR (#11157 )
• apollo_proof_manager: add proof manager client to the transaction converter #11044
• apollo_node: integrate proof manager server #11043
• apollo_node: integrate proof manager client into node #11042
• apollo_proof_manager: add metrics file #11041
• apollo_http_server: turn off unsupported tx version test #11625
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[reviewable-StarkWare]

This change is 

[noaov1]

@noaov1 reviewed 3 files and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @einat-starkware).

[noaov1]

@noaov1 made 3 comments.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @einat-starkware).

---

crates/apollo_gateway/src/large_storage_writer.rs line 13 at r1 (raw file):

pub trait LargeStorageWriterTrait: Send + Sync {
    async fn set_proof(&self, facts_hash: Felt, proof: Proof) -> Result<(), LargeStorageError>;
}

Suggestion:

pub trait ProofArchiveWriterTrait: Send + Sync {
    async fn set_proof(&self, facts_hash: Felt, proof: Proof) -> Result<(), LargeStorageError>;
}

---

crates/apollo_gateway/src/large_storage_writer.rs line 16 at r1 (raw file):

#[derive(Debug, Error)]
pub enum LargeStorageError {

Suggestion:

pub enum ProofArchiveError {

---

crates/apollo_gateway/src/large_storage_writer.rs line 23 at r1 (raw file):

#[derive(Clone, Default)]
// TODO(Einat): Add GCS related fields.
pub struct LargeStorageWriter;

Suggestion:

pub struct GcsProofArchiveWriter;

[noaov1]

@noaov1 partially reviewed 2 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @avivg-starkware).