apollo_proof_manager: calculate hash within the proof storage

[einat-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[einat-starkware]

• apollo_batcher: delete proof validator and move proof verification to transaction converter #11421 : 2 dependent PRs (#11141 , #11157 )
• apollo_proof_manager: add proof manager client to the transaction converter #11044
• apollo_node: integrate proof manager server #11043
• apollo_node: integrate proof manager client into node #11042
• apollo_proof_manager: add metrics file #11041
• apollo_proof_manager: component request handler #11040
• apollo_proof_manager: implement component starter #11039
• apollo_proof_manager_types: create proof manager client #10965
• apollo_proof_manager: calculate hash within the proof storage #11382 👈 (View in Graphite)
• apollo_proof_manager: enable proof manager and add to deployments #11274
• apollo_proof_manager: add proof manager to node config and components #10956
• apollo_node_config: add proof manager config to node config #11242
• apollo_proof_manager: create proof manager #10943
• apollo_proof_manager: test fs proof storage #10902
• apollo_proof_manager: impl ProofStorage #10901
• apollo_proof_manager: read/write proof from file methods #10899
• apollo_proof_manager: add fs directory methods #10862
• apollo_proof_manager: add ProofStorage trait #10798
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[noaov1]

@noaov1 reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @einat-starkware).

[noaov1]

@noaov1 made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @einat-starkware).

---

crates/apollo_proof_manager/src/proof_storage.rs line 20 at r1 (raw file):

    fn set_proof(&self, proof_facts: ProofFacts, proof: Proof) -> Result<(), Self::Error>;
    fn get_proof(&self, proof_facts: ProofFacts) -> Result<Option<Proof>, Self::Error>;
    fn contains_proof(&self, proof_facts: ProofFacts) -> Result<bool, Self::Error>;

Do you need an actual copy of the proof facts?

Suggestion:

    fn set_proof(&self, proof_facts: &ProofFacts, proof: Proof) -> Result<(), Self::Error>;
    fn get_proof(&self, proof_facts: &ProofFacts) -> Result<Option<Proof>, Self::Error>;
    fn contains_proof(&self, proof_facts: &ProofFacts) -> Result<bool, Self::Error>;

[einat-starkware]

@einat-starkware made 1 comment.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @noaov1).

---

crates/apollo_proof_manager/src/proof_storage.rs line 20 at r1 (raw file):

Previously, noaov1 (Noa Oved) wrote…

Do you need an actual copy of the proof facts?

You're right, I don't need it :), updated to use a reference

[einat-starkware]

@einat-starkware made 1 comment.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @noaov1).

---

crates/apollo_proof_manager/src/proof_storage.rs line 20 at r1 (raw file):

Previously, einat-starkware wrote…

You're right, I don't need it :), updated to use a reference

Never mind, I actually do need the proof_facts themselves because for reasons relating to the serde and async requirements in the client, I would need to clone in the client anyways and all the interaction with the proof manager happens through the client so I would be cloning anyways, so there's no benefit to using a reference here. Regardless, the proof facts is wrapped in Arc so the benefit is negligible anyways to avoiding the clone

[einat-starkware]

@einat-starkware resolved 1 discussion.
Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @noaov1).

[graphite-app]

Merge activity

• Jan 11, 11:55 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

[einat-starkware]

@einat-starkware reviewed 3 files and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @einat-starkware).