-
Notifications
You must be signed in to change notification settings - Fork 65
apollo_node_config: add proof manager config to node config #11242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bd7d1ae to
b17fef6
Compare
243fba6 to
fec8bf9
Compare
fec8bf9 to
c2a9408
Compare
c2a9408 to
b88ba61
Compare
b17fef6 to
54bd1d9
Compare
b88ba61 to
ba668d9
Compare
Merge activity
|
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Itay-Tsabary-Starkware partially reviewed 15 files and made 1 comment.
Reviewable status: 14 of 57 files reviewed, 1 unresolved discussion (waiting on @einat-starkware).
crates/apollo_integration_tests/src/state_reader.rs line 72 at r3 (raw file):
pub(crate) const STATE_SYNC_DB_PATH_SUFFIX: &str = "state_sync"; pub(crate) const CONSENSUS_DB_PATH_SUFFIX: &str = "consensus";
Add a new line here please
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Itay-Tsabary-Starkware made 1 comment.
Reviewable status: 14 of 57 files reviewed, 2 unresolved discussions (waiting on @einat-starkware).
crates/apollo_integration_tests/src/storage.rs line 49 at r3 (raw file):
&self.path } pub fn get_proof_manager_exec_path(&self) -> &PathBuf {
New line between fns please 🙏
Code quote:
pub fn get_proof_m
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Itay-Tsabary-Starkware made 1 comment.
Reviewable status: 14 of 57 files reviewed, 3 unresolved discussions (waiting on @einat-starkware).
crates/apollo_integration_tests/src/state_reader.rs line 2 at r3 (raw file):
use std::collections::HashMap;
Are the integration_test changes required as part of this pr, or can they be in a different one?
ba668d9 to
01b121b
Compare
einat-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@einat-starkware made 3 comments.
Reviewable status: 14 of 57 files reviewed, 3 unresolved discussions (waiting on @Itay-Tsabary-Starkware).
crates/apollo_integration_tests/src/state_reader.rs line 2 at r3 (raw file):
Previously, Itay-Tsabary-Starkware wrote…
Are the
integration_testchanges required as part of this pr, or can they be in a different one?
Yes, I have to add the config for it to pass the CI; technically, I could put in a dummy and change in a later PR but the dummy was enough changes that I just decided to put in the actual changes.
crates/apollo_integration_tests/src/state_reader.rs line 72 at r3 (raw file):
Previously, Itay-Tsabary-Starkware wrote…
Add a new line here please
Done.
crates/apollo_integration_tests/src/storage.rs line 49 at r3 (raw file):
Previously, Itay-Tsabary-Starkware wrote…
New line between fns please 🙏
Done.
01b121b to
60524ce
Compare
7b66ab7 to
17ecdc5
Compare
17ecdc5 to
99164a9
Compare
764a24b to
9190045
Compare
9190045 to
6b880e6
Compare
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Itay-Tsabary-Starkware reviewed 51 files and all commit messages, and resolved 3 discussions.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @einat-starkware).

No description provided.