Skip to content

Conversation

@einat-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

einat-starkware commented Dec 29, 2025

@einat-starkware einat-starkware marked this pull request as ready for review December 29, 2025 11:38
@einat-starkware einat-starkware changed the base branch from einat/proof_manager/proof_manager to graphite-base/11242 December 29, 2025 11:46
@einat-starkware einat-starkware force-pushed the einat/proof_manager/add_to_config branch from 243fba6 to fec8bf9 Compare December 29, 2025 12:09
@einat-starkware einat-starkware changed the base branch from graphite-base/11242 to einat/proof_manager/proof_manager December 29, 2025 12:09
@einat-starkware einat-starkware force-pushed the einat/proof_manager/add_to_config branch from fec8bf9 to c2a9408 Compare December 29, 2025 15:12
@einat-starkware einat-starkware force-pushed the einat/proof_manager/add_to_config branch from c2a9408 to b88ba61 Compare December 31, 2025 10:01
@einat-starkware einat-starkware force-pushed the einat/proof_manager/proof_manager branch from b17fef6 to 54bd1d9 Compare December 31, 2025 10:01
@einat-starkware einat-starkware changed the base branch from einat/proof_manager/proof_manager to main December 31, 2025 11:55
@einat-starkware einat-starkware force-pushed the einat/proof_manager/add_to_config branch from b88ba61 to ba668d9 Compare December 31, 2025 11:56
@graphite-app
Copy link

graphite-app bot commented Dec 31, 2025

Merge activity

  • Dec 31, 11:56 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

Copy link
Collaborator

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Itay-Tsabary-Starkware partially reviewed 15 files and made 1 comment.
Reviewable status: 14 of 57 files reviewed, 1 unresolved discussion (waiting on @einat-starkware).


crates/apollo_integration_tests/src/state_reader.rs line 72 at r3 (raw file):

pub(crate) const STATE_SYNC_DB_PATH_SUFFIX: &str = "state_sync";
pub(crate) const CONSENSUS_DB_PATH_SUFFIX: &str = "consensus";

Add a new line here please

Copy link
Collaborator

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Itay-Tsabary-Starkware made 1 comment.
Reviewable status: 14 of 57 files reviewed, 2 unresolved discussions (waiting on @einat-starkware).


crates/apollo_integration_tests/src/storage.rs line 49 at r3 (raw file):

        &self.path
    }
    pub fn get_proof_manager_exec_path(&self) -> &PathBuf {

New line between fns please 🙏

Code quote:

 pub fn get_proof_m

Copy link
Collaborator

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Itay-Tsabary-Starkware made 1 comment.
Reviewable status: 14 of 57 files reviewed, 3 unresolved discussions (waiting on @einat-starkware).


crates/apollo_integration_tests/src/state_reader.rs line 2 at r3 (raw file):

use std::collections::HashMap;

Are the integration_test changes required as part of this pr, or can they be in a different one?

@einat-starkware einat-starkware force-pushed the einat/proof_manager/add_to_config branch from ba668d9 to 01b121b Compare January 1, 2026 08:06
Copy link
Contributor Author

@einat-starkware einat-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@einat-starkware made 3 comments.
Reviewable status: 14 of 57 files reviewed, 3 unresolved discussions (waiting on @Itay-Tsabary-Starkware).


crates/apollo_integration_tests/src/state_reader.rs line 2 at r3 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Are the integration_test changes required as part of this pr, or can they be in a different one?

Yes, I have to add the config for it to pass the CI; technically, I could put in a dummy and change in a later PR but the dummy was enough changes that I just decided to put in the actual changes.


crates/apollo_integration_tests/src/state_reader.rs line 72 at r3 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Add a new line here please

Done.


crates/apollo_integration_tests/src/storage.rs line 49 at r3 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

New line between fns please 🙏

Done.

@einat-starkware einat-starkware force-pushed the einat/proof_manager/add_to_config branch from 9190045 to 6b880e6 Compare January 10, 2026 21:38
Copy link
Collaborator

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Itay-Tsabary-Starkware reviewed 51 files and all commit messages, and resolved 3 discussions.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @einat-starkware).

@einat-starkware einat-starkware added this pull request to the merge queue Jan 11, 2026
Merged via the queue into main with commit a621093 Jan 11, 2026
34 of 36 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants