apollo_proof_manager: impl ProofStorage

[einat-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[einat-starkware]

• apollo_batcher: delete proof validator and move proof verification to transaction converter #11421 : 2 dependent PRs (#11141 , #11157 )
• apollo_proof_manager: add proof manager client to the transaction converter #11044
• apollo_node: integrate proof manager server #11043
• apollo_node: integrate proof manager client into node #11042
• apollo_proof_manager: add metrics file #11041
• apollo_proof_manager: component request handler #11040
• apollo_proof_manager: implement component starter #11039
• apollo_proof_manager_types: create proof manager client #10965
• apollo_proof_manager: calculate hash within the proof storage #11382
• apollo_proof_manager: enable proof manager and add to deployments #11274
• apollo_proof_manager: add proof manager to node config and components #10956
• apollo_node_config: add proof manager config to node config #11242
• apollo_proof_manager: create proof manager #10943
• apollo_proof_manager: test fs proof storage #10902
• apollo_proof_manager: impl ProofStorage #10901 👈 (View in Graphite)
• apollo_proof_manager: read/write proof from file methods #10899
• apollo_proof_manager: add fs directory methods #10862
• apollo_proof_manager: add ProofStorage trait #10798
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[noaov1]

@noaov1 reviewed 1 file and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @AvivYossef-starkware and @einat-starkware).

---

crates/apollo_proof_manager/src/proof_storage.rs line 130 at r1 (raw file):

    }

    fn write_proof_atomically(&self, facts_hash: Felt, proof: Proof) -> FsProofStorageResult<()> {

Why is it needed? 🤔

Code quote:

    fn write_proof_atomically(&self, facts_hash: Felt, proof: Proof) -> FsProofStorageResult<()> {

---

crates/apollo_proof_manager/src/proof_storage.rs line 151 at r1 (raw file):

    fn get_proof(&self, facts_hash: Felt) -> Result<Option<Proof>, Self::Error> {
        match self.read_proof_from_file(facts_hash) {

When do you return Ok(None)?

Code quote:

        match self.read_proof_from_file(facts_hash) {

[einat-starkware]

@einat-starkware made 2 comments.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @AvivYossef-starkware and @noaov1).

---

crates/apollo_proof_manager/src/proof_storage.rs line 130 at r1 (raw file):

Previously, noaov1 (Noa Oved) wrote…

Why is it needed? 🤔

I followed the same logic as the class storage - if it crashes in the middle of writing the proof, it won't return an empty file or a partial write, but will instead be as if the write never happened

---

crates/apollo_proof_manager/src/proof_storage.rs line 151 at r1 (raw file):

Previously, noaov1 (Noa Oved) wrote…

When do you return Ok(None)?

If it doesn't contain the proof - i added in a check :)

[noaov1]

@noaov1 reviewed 1 file and all commit messages, made 1 comment, and resolved 2 discussions.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware).

[noaov1]

@noaov1 reviewed 1 file and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware).

[graphite-app]

Merge activity

• Dec 28, 1:13 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.