apollo_proof_manager: create proof manager

[einat-starkware]

No description provided.

[einat-starkware]

• apollo_batcher: delete proof validator and move proof verification to transaction converter #11421 : 2 dependent PRs (#11141 , #11157 )
• apollo_proof_manager: add proof manager client to the transaction converter #11044
• apollo_node: integrate proof manager server #11043
• apollo_node: integrate proof manager client into node #11042
• apollo_proof_manager: add metrics file #11041
• apollo_proof_manager: component request handler #11040
• apollo_proof_manager: implement component starter #11039
• apollo_proof_manager_types: create proof manager client #10965
• apollo_proof_manager: calculate hash within the proof storage #11382
• apollo_proof_manager: enable proof manager and add to deployments #11274
• apollo_proof_manager: add proof manager to node config and components #10956
• apollo_node_config: add proof manager config to node config #11242
• apollo_proof_manager: create proof manager #10943 👈 (View in Graphite)
• apollo_proof_manager: test fs proof storage #10902
• apollo_proof_manager: impl ProofStorage #10901
• apollo_proof_manager: read/write proof from file methods #10899
• apollo_proof_manager: add fs directory methods #10862
• apollo_proof_manager: add ProofStorage trait #10798
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[reviewable-StarkWare]

This change is 

[noaov1]

@noaov1 reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @einat-starkware).

---

crates/apollo_proof_manager/src/proof_manager.rs line 17 at r1 (raw file):

pub struct ProofManager {
    pub proof_storage: FsProofStorage,
    pub proof_manager_config: ProofManagerConfig,

Is it needed after creating the struct?

Code quote:

    pub proof_manager_config: ProofManagerConfig,

[github-actions]

Artifacts upload workflows:

• Started at 2025-12-22T09:27:36Z
• Started at 2025-12-22T14:50:22Z
• Started at 2025-12-25T10:28:40Z
• Started at 2025-12-28T11:08:53Z
• Started at 2025-12-28T13:46:52Z
• Started at 2025-12-28T13:49:53Z
• Started at 2025-12-28T14:26:53Z
• Started at 2025-12-29T08:28:45Z
• Started at 2025-12-29T08:32:36Z
• Started at 2025-12-29T11:36:40Z
• Started at 2025-12-29T11:47:05Z
• Started at 2025-12-31T10:01:51Z

[einat-starkware]

@einat-starkware made 1 comment.
Reviewable status: 1 of 5 files reviewed, 1 unresolved discussion (waiting on @noaov1).

---

crates/apollo_proof_manager/src/proof_manager.rs line 17 at r1 (raw file):

Previously, noaov1 (Noa Oved) wrote…

Is it needed after creating the struct?

No, at least not currently, removed now :)

[einat-starkware]

@einat-starkware made 1 comment.
Reviewable status: 3 of 5 files reviewed, 1 unresolved discussion (waiting on @noaov1).

---

crates/apollo_proof_manager/src/proof_manager.rs line 62 at r3 (raw file):

Previously, noaov1 (Noa Oved) wrote…

Why is it needed?

Removed (I was following the pattern from other components but it is not necessary).

[Itay-Tsabary-Starkware]

@Itay-Tsabary-Starkware made 1 comment.
Reviewable status: 3 of 5 files reviewed, 2 unresolved discussions (waiting on @einat-starkware and @noaov1).

---

crates/apollo_proof_manager/src/proof_manager.rs line 32 at r5 (raw file):

        )])
    }
}

Please move this to a new crate: apollo_proof_manager_config 🙏

Code quote:

/// Configuration for the proof manager.
#[derive(Clone, Debug, Serialize, Deserialize, PartialEq, Validate)]
pub struct ProofManagerConfig {
    pub persistent_root: PathBuf,
}
impl Default for ProofManagerConfig {
    fn default() -> Self {
        Self { persistent_root: "/data/proofs".into() }
    }
}
impl SerializeConfig for ProofManagerConfig {
    fn dump(&self) -> BTreeMap<ParamPath, SerializedParam> {
        BTreeMap::from([ser_param(
            "persistent_root",
            &self.persistent_root,
            "Persistent root for proof storage.",
            ParamPrivacyInput::Public,
        )])
    }
}

[Itay-Tsabary-Starkware]

@Itay-Tsabary-Starkware made 1 comment.
Reviewable status: 3 of 5 files reviewed, 3 unresolved discussions (waiting on @einat-starkware and @noaov1).

---

crates/apollo_proof_manager/src/lib.rs line 5 at r5 (raw file):

pub use proof_manager::{ProofManager, ProofManagerConfig};
pub use proof_storage::ProofStorage;

Why re-export?

Code quote:

pub use proof_manager::{ProofManager, ProofManagerConfig};
pub use proof_storage::ProofStorage;

[einat-starkware]

@einat-starkware made 2 comments.
Reviewable status: 1 of 9 files reviewed, 3 unresolved discussions (waiting on @Itay-Tsabary-Starkware and @noaov1).

---

crates/apollo_proof_manager/src/lib.rs line 5 at r5 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Why re-export?

a mistake, removed now

---

crates/apollo_proof_manager/src/proof_manager.rs line 32 at r5 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Please move this to a new crate: apollo_proof_manager_config 🙏

Moved to new crate

[noaov1]

@noaov1 reviewed 8 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Itay-Tsabary-Starkware).

[Itay-Tsabary-Starkware]

@Itay-Tsabary-Starkware made 1 comment and resolved 2 discussions.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @einat-starkware).

---

crates/apollo_proof_manager_config/Cargo.toml line 7 at r7 (raw file):

repository.workspace = true
version.workspace = true

Please add a description field 🙏

[Itay-Tsabary-Starkware]

@Itay-Tsabary-Starkware made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @einat-starkware).

---

crates/apollo_proof_manager_config/src/config.rs line 13 at r7 (raw file):

pub struct ProofManagerConfig {
    pub persistent_root: PathBuf,
}

Please add new-lines after struct / impl blocks 🙏

[einat-starkware]

@einat-starkware made 2 comments.
Reviewable status: 7 of 9 files reviewed, 2 unresolved discussions (waiting on @Itay-Tsabary-Starkware and @noaov1).

---

crates/apollo_proof_manager_config/Cargo.toml line 7 at r7 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Please add a description field 🙏

Done.

---

crates/apollo_proof_manager_config/src/config.rs line 13 at r7 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Please add new-lines after struct / impl blocks 🙏

Done.

[Itay-Tsabary-Starkware]

@Itay-Tsabary-Starkware reviewed 9 files and all commit messages, made 1 comment, and resolved 2 discussions.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @einat-starkware).