Skip to content

Conversation

@einat-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@einat-starkware einat-starkware marked this pull request as ready for review December 17, 2025 09:41
@github-actions
Copy link

github-actions bot commented Dec 17, 2025

Copy link
Contributor Author

einat-starkware commented Dec 17, 2025

Copy link
Collaborator

@noaov1 noaov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noaov1 reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @einat-starkware)


crates/apollo_proof_manager/src/proof_storage.rs line 33 at r1 (raw file):

        Ok(Self { persistent_root })
    }

Consider sharing code with the class storage.

@einat-starkware einat-starkware changed the base branch from einat/12-14-apollo_proof_manager_add_proofstorage_trait to graphite-base/10862 December 21, 2025 07:33
@einat-starkware einat-starkware force-pushed the einat/proof_manager/create_directory_methods branch from ac3f33c to 4ab3e73 Compare December 21, 2025 07:37
@einat-starkware einat-starkware changed the base branch from graphite-base/10862 to einat/12-14-apollo_proof_manager_add_proofstorage_trait December 21, 2025 07:37
Copy link
Contributor Author

@einat-starkware einat-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@einat-starkware made 1 comment.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @noaov1).


crates/apollo_proof_manager/src/proof_storage.rs line 33 at r1 (raw file):

Previously, noaov1 (Noa Oved) wrote…

Consider sharing code with the class storage.

Added a TODO for this

Copy link
Collaborator

@noaov1 noaov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@noaov1 reviewed 1 file and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @einat-starkware).


crates/apollo_proof_manager/src/proof_storage.rs line 33 at r1 (raw file):

Previously, einat-starkware wrote…

Added a TODO for this

Please also add it to the Monday :)

@einat-starkware einat-starkware force-pushed the einat/proof_manager/create_directory_methods branch from 4ab3e73 to fd66ca7 Compare December 21, 2025 14:47
@einat-starkware einat-starkware force-pushed the einat/12-14-apollo_proof_manager_add_proofstorage_trait branch from f6a6060 to fdf270f Compare December 21, 2025 14:47
Copy link
Collaborator

@noaov1 noaov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noaov1 reviewed 1 file and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @einat-starkware).

Copy link
Contributor Author

@einat-starkware einat-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@einat-starkware resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware).

@einat-starkware einat-starkware changed the base branch from einat/12-14-apollo_proof_manager_add_proofstorage_trait to main December 22, 2025 08:17
@einat-starkware einat-starkware force-pushed the einat/proof_manager/create_directory_methods branch from fd66ca7 to 49578a5 Compare December 22, 2025 08:20
@graphite-app
Copy link

graphite-app bot commented Dec 22, 2025

Merge activity

  • Dec 22, 8:21 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@einat-starkware einat-starkware force-pushed the einat/proof_manager/create_directory_methods branch from 49578a5 to b1a794c Compare December 22, 2025 08:25
@einat-starkware einat-starkware added this pull request to the merge queue Dec 22, 2025
Merged via the queue into main with commit 160ef51 Dec 22, 2025
32 of 33 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants