-
Notifications
You must be signed in to change notification settings - Fork 65
apollo_proof_manager: add fs directory methods #10862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apollo_proof_manager: add fs directory methods #10862
Conversation
noaov1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@noaov1 reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @einat-starkware)
crates/apollo_proof_manager/src/proof_storage.rs line 33 at r1 (raw file):
Ok(Self { persistent_root }) }
Consider sharing code with the class storage.
cf18757 to
f6a6060
Compare
ac3f33c to
4ab3e73
Compare
einat-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@einat-starkware made 1 comment.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @noaov1).
crates/apollo_proof_manager/src/proof_storage.rs line 33 at r1 (raw file):
Previously, noaov1 (Noa Oved) wrote…
Consider sharing code with the class storage.
Added a TODO for this
noaov1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@noaov1 reviewed 1 file and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @einat-starkware).
crates/apollo_proof_manager/src/proof_storage.rs line 33 at r1 (raw file):
Previously, einat-starkware wrote…
Added a TODO for this
Please also add it to the Monday :)
4ab3e73 to
fd66ca7
Compare
f6a6060 to
fdf270f
Compare
noaov1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@noaov1 reviewed 1 file and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @einat-starkware).
einat-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@einat-starkware resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @AvivYossef-starkware).
fd66ca7 to
49578a5
Compare
Merge activity
|
49578a5 to
b1a794c
Compare

No description provided.