apollo_proof_manager: add ProofStorage trait

[einat-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[github-actions]

Artifacts upload workflows:

• Started at 2025-12-15T12:12:20Z
• Started at 2025-12-15T12:25:39Z
• Started at 2025-12-15T12:36:09Z
• Started at 2025-12-15T13:05:00Z
• Started at 2025-12-21T07:33:07Z
• Started at 2025-12-21T14:47:36Z

[einat-starkware]

• apollo_batcher: delete proof validator and move proof verification to transaction converter #11421 : 2 dependent PRs (#11141 , #11157 )
• apollo_proof_manager: add proof manager client to the transaction converter #11044
• apollo_node: integrate proof manager server #11043
• apollo_node: integrate proof manager client into node #11042
• apollo_proof_manager: add metrics file #11041
• apollo_proof_manager: component request handler #11040
• apollo_proof_manager: implement component starter #11039
• apollo_proof_manager_types: create proof manager client #10965
• apollo_proof_manager: calculate hash within the proof storage #11382
• apollo_proof_manager: enable proof manager and add to deployments #11274
• apollo_proof_manager: add proof manager to node config and components #10956
• apollo_node_config: add proof manager config to node config #11242
• apollo_proof_manager: create proof manager #10943
• apollo_proof_manager: test fs proof storage #10902
• apollo_proof_manager: impl ProofStorage #10901
• apollo_proof_manager: read/write proof from file methods #10899
• apollo_proof_manager: add fs directory methods #10862
• apollo_proof_manager: add ProofStorage trait #10798 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[noaov1]

@noaov1 reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @einat-starkware)

[noaov1]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @einat-starkware)

---

crates/apollo_proof_manager/src/proof_storage.rs line 10 at r1 (raw file):

    fn set_proof(&self, facts_hash: Felt, proof: Proof) -> Result<(), Self::Error>;
    fn get_proof(&self, facts_hash: Felt) -> Result<Option<Proof>, Self::Error>;
}

Please add an "is exist" method

[noaov1]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @einat-starkware)

---

crates/apollo_proof_manager/src/proof_storage.rs line 10 at r1 (raw file):

Previously, noaov1 (Noa Oved) wrote…

Please add an "is exist" method

Or "contains_proof"

[einat-starkware]

@einat-starkware made 1 comment.
Reviewable status: 6 of 7 files reviewed, 1 unresolved discussion (waiting on @noaov1).

---

crates/apollo_proof_manager/src/proof_storage.rs line 10 at r1 (raw file):

Previously, noaov1 (Noa Oved) wrote…

Or "contains_proof"

Done.

[noaov1]

@noaov1 reviewed 1 file and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @einat-starkware).

[noaov1]

@noaov1 reviewed 3 files and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @einat-starkware).