apollo_integration_tests: clean old todos

[ArniStarkware]

No description provided.

[reviewable-StarkWare]

This change is 

[ArniStarkware]

• apollo_integration_tests: add proposal margins to end to end flow args #11670
• apollo_integration_tests: merge test utils files #11698
• apollo_integration_tests: rename test scenario to a specific name #11697
• apollo_integration_tests: move common mod to end to end flow utils #11646
• apollo_integration_tests: simplify scenario arg in end to end flow #11505
• apollo_integration_tests: split end to end flow test into 5 scenarios #11504
• apollo_integration_tests: use validate_tx_count accross integration tests #11503
• apollo_integration_tests: clean old todos #11502 👈 (View in Graphite)
• apollo_integration_tests: rename reverted_l1_handler_tx_flow_test file #11501
• main-v0.14.1-committer

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Itay-Tsabary-Starkware]

@Itay-Tsabary-Starkware made 1 comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @ArniStarkware, @meship-starkware, and @TzahiTaub).

---

crates/apollo_integration_tests/tests/common/mod.rs line 4 at r1 (raw file):

// This means that any peace of code in this module that is not used by *all* test modules will be
// identified as unused code by clippy (for one of the crates).
#![allow(dead_code)]

Why do we have a tests/common/mod.rs module here?
Are these utilities used by all/some of the integration tests? We can simply move them to src/utils then, the entire purpose of this crate is testing, so we don't need to go the extra mile of separating testing utils into a hacky tests/src-code-stuff hierarchy.

@ArniStarkware could you add a todo for that?

Code quote:

// Each test module is compiled as a separate crate, and all can declare the common module.
// This means that any peace of code in this module that is not used by *all* test modules will be
// identified as unused code by clippy (for one of the crates).
#![allow(dead_code)]

[ArniStarkware]

@ArniStarkware made 1 comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware, @meship-starkware, and @TzahiTaub).

---

crates/apollo_integration_tests/tests/common/mod.rs line 4 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

Why do we have a tests/common/mod.rs module here?
Are these utilities used by all/some of the integration tests? We can simply move them to src/utils then, the entire purpose of this crate is testing, so we don't need to go the extra mile of separating testing utils into a hacky tests/src-code-stuff hierarchy.

@ArniStarkware could you add a todo for that?

Done.

[meship-starkware]

@meship-starkware made 1 comment.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @ArniStarkware, @Itay-Tsabary-Starkware, and @TzahiTaub).

---

crates/apollo_integration_tests/tests/end_to_end_flow_test.rs line 18 at r2 (raw file):

mod common;

// TODO(Meshi): Fail the test if no class have migrated.

Would the test fail if the migration fails? I am not sure if this is done.

Code quote:

// TODO(Meshi): Fail the test if no class have migrated.

[ArniStarkware]

@ArniStarkware made 1 comment.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @Itay-Tsabary-Starkware, @meship-starkware, and @TzahiTaub).

---

crates/apollo_integration_tests/tests/end_to_end_flow_test.rs line 18 at r2 (raw file):

Previously, meship-starkware (Meshi Peled) wrote…

Would the test fail if the migration fails? I am not sure if this is done.

I will bring this TODO back and move this todo in this PR: 11504

[meship-starkware]

@meship-starkware resolved 1 discussion.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware and @TzahiTaub).

[meship-starkware]

@meship-starkware reviewed 2 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware and @TzahiTaub).

[Itay-Tsabary-Starkware]

@Itay-Tsabary-Starkware reviewed 2 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub).

[ArniStarkware]

@ArniStarkware reviewed 1 file and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @TzahiTaub).