Skip to content

apollo_dashboard: fix batcher failed txs panel #11570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Itay-Tsabary-Starkware merged 1 commit into from
Jan 11, 2026
Merged

apollo_dashboard: fix batcher failed txs panel #11570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/apollo_dashboard/resources/dev_grafana.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,8 +383,8 @@
}
},
{
"title": "Rejected / Reverted TXs Ratio",
"description": "Ratio of rejected / reverted transactions out of all processed txs (10m window)",
"title": "Rate of Rejected and Reverted TXs Ratio",
"description": "Rates of the rejected and reverted transactions ratios of all processed txs (10m window)",
"type": "timeseries",
"exprs": [
"increase(batcher_rejected_transactions{cluster=~\"$cluster\", namespace=~\"$namespace\"}[10m]) / (increase(batcher_rejected_transactions{cluster=~\"$cluster\", namespace=~\"$namespace\"}[10m]) + increase(batcher_reverted_transactions{cluster=~\"$cluster\", namespace=~\"$namespace\"}[10m]) + increase(batcher_batched_transactions{cluster=~\"$cluster\", namespace=~\"$namespace\"}[10m]))",
Expand Down
13 changes: 5 additions & 8 deletions crates/apollo_dashboard/src/panels/batcher.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,17 +67,14 @@ fn get_panel_storage_height() -> Panel {
fn get_panel_rejection_reverted_ratio() -> Panel {
let rejected_txs_expr = increase(&REJECTED_TRANSACTIONS, DEFAULT_DURATION);
let reverted_txs_expr = increase(&REVERTED_TRANSACTIONS, DEFAULT_DURATION);
let batched_txs_expr = increase(&BATCHED_TRANSACTIONS, DEFAULT_DURATION);

let denominator_expr = format!(
"({} + {} + {})",
rejected_txs_expr,
reverted_txs_expr,
increase(&BATCHED_TRANSACTIONS, DEFAULT_DURATION),
);
let denominator_expr =
format!("({} + {} + {})", rejected_txs_expr, reverted_txs_expr, batched_txs_expr,);
Panel::new(
"Rejected / Reverted TXs Ratio",
"Rate of Rejected and Reverted TXs Ratio",
format!(
"Ratio of rejected / reverted transactions out of all processed txs \
"Rates of the rejected and reverted transactions ratios of all processed txs \
({DEFAULT_DURATION} window)"
),
vec![
Expand Down