apollo_dashboard: fix batcher failed txs panel

[Itay-Tsabary-Starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[Itay-Tsabary-Starkware]

• apollo_dashboard: fix batcher failed txs panel #11570 👈 (View in Graphite)
• apollo_deployments: add missing committer in batcher config #11573 : 4 other dependent PRs (#11354 , #11393 , #11454 and 1 other)
• main-v0.14.1-committer

This stack of pull requests is managed by Graphite. Learn more about stacking.

[matanl-starkware]

@matanl-starkware made 1 comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware).

---

crates/apollo_dashboard/src/panels/batcher.rs line 68 at r1 (raw file):

fn get_panel_rejection_reverted_ratio() -> Panel {
    let rejected_txs_expr = &REJECTED_TRANSACTIONS.get_name_with_filter();

I don't think this is better.
When looking at the entire counter (as opposed to an increase), it's almost impossible to spot recent changes.
IMO the formula should be:
increase(X) / increase(X +Y + Z)

Code quote:

&REJECTED_TRANSACTIONS.get_name_with_filter();

[Itay-Tsabary-Starkware]

@Itay-Tsabary-Starkware made 1 comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @matanl-starkware).

---

crates/apollo_dashboard/src/panels/batcher.rs line 68 at r1 (raw file):

Previously, matanl-starkware (Matan Lior) wrote…

I don't think this is better.
When looking at the entire counter (as opposed to an increase), it's almost impossible to spot recent changes.
IMO the formula should be:
increase(X) / increase(X +Y + Z)

What does this value represent?

Why not increase(X / (X +Y + Z)) ?

[Itay-Tsabary-Starkware]

@Itay-Tsabary-Starkware made 1 comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @matanl-starkware).

---

crates/apollo_dashboard/src/panels/batcher.rs line 68 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

What does this value represent?

Why not increase(X / (X +Y + Z)) ?

... if the motivation is to track changes in X / (X +Y + Z) in an easier manner

[matanl-starkware]

@matanl-starkware made 1 comment.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware).

---

crates/apollo_dashboard/src/panels/batcher.rs line 68 at r1 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

... if the motivation is to track changes in X / (X +Y + Z) in an easier manner

According to Chat:
increase(X / (X+Y)) should not be ever used ("Apply increase() / rate() to the raw counters first, and only then compute ratios.")

Between these options, it recommends B ("This avoids subtle issues with label matching and aggregation.")
A. increase(X) / increase(X+Y)
B. increase(X) / (increase(X) + increase(Y))

[matanl-starkware]

@matanl-starkware made 1 comment.
Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @Itay-Tsabary-Starkware).

---

crates/apollo_deployments/resources/app_configs/batcher_config.json line 27 at r3 (raw file):

  "batcher_config.commitment_manager_config.results_channel_size": 1000,
  "batcher_config.commitment_manager_config.tasks_channel_size":  1000,
  "batcher_config.commitment_manager_config.wait_for_tasks_channel": true,

Seems unrelated to this PR

Code quote:

  "batcher_config.commitment_manager_config.results_channel_size": 1000,
  "batcher_config.commitment_manager_config.tasks_channel_size":  1000,
  "batcher_config.commitment_manager_config.wait_for_tasks_channel": true,

[Itay-Tsabary-Starkware]

@Itay-Tsabary-Starkware made 1 comment.
Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @matanl-starkware).

---

crates/apollo_dashboard/src/panels/batcher.rs line 68 at r1 (raw file):

Previously, matanl-starkware (Matan Lior) wrote…

According to Chat:
increase(X / (X+Y)) should not be ever used ("Apply increase() / rate() to the raw counters first, and only then compute ratios.")

Between these options, it recommends B ("This avoids subtle issues with label matching and aggregation.")
A. increase(X) / increase(X+Y)
B. increase(X) / (increase(X) + increase(Y))

Done.

[matanl-starkware]

@matanl-starkware reviewed 2 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: 2 of 4 files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware).

---

-- commits line 2 at r5:
Consider adjusting the commit message according to actual change

Code quote:

fix batcher failed txs panel

[matanl-starkware]

@matanl-starkware resolved 1 discussion.
Reviewable status: 2 of 4 files reviewed, all discussions resolved.

[Itay-Tsabary-Starkware]

@Itay-Tsabary-Starkware reviewed 4 files and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware).