apollo_http_server: use allow new tx flag

[Itay-Tsabary-Starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[Itay-Tsabary-Starkware]

• apollo_http_server: polling interval in config #11537
• apollo_http_server: add dynamic config poller service #11534
• apollo_http_server: use allow new tx flag #11454 👈 (View in Graphite)
• apollo_deployments: add missing committer in batcher config #11573 : 4 other dependent PRs (#11354 , #11393 , #11570 and 1 other)
• main-v0.14.1-committer

This stack of pull requests is managed by Graphite. Learn more about stacking.

[matanl-starkware]

@matanl-starkware made 2 comments.
Reviewable status: 0 of 5 files reviewed, 2 unresolved discussions (waiting on @Itay-Tsabary-Starkware).

---

crates/apollo_http_server/src/http_server_test.rs line 108 at r1 (raw file):

    let response = http_client.add_tx(tx.clone()).await;
    let status = response.status();
    assert!(!status.is_success(), "{status:?}");

Please verify the return code is 503 (and not some other error that might have happened during add_tx)

Code quote:

assert!(!status.is_success(), "{status:?}");

---

crates/apollo_http_server/src/http_server.rs line 106 at r1 (raw file):

            .route(
                "/gateway/is_ready",
                get(|| futures::future::ready("Gateway is ready".to_owned()))

Consider modifying this to be unready...
(Probably requires a shared dynamic config, as suggested in previous PR)

Code quote:

get(|| futures::future::ready("Gateway is ready".to_owned()))

[Itay-Tsabary-Starkware]

@Itay-Tsabary-Starkware made 2 comments.
Reviewable status: 0 of 5 files reviewed, 2 unresolved discussions (waiting on @matanl-starkware).

---

crates/apollo_http_server/src/http_server.rs line 106 at r1 (raw file):

Previously, matanl-starkware (Matan Lior) wrote…

Consider modifying this to be unready...
(Probably requires a shared dynamic config, as suggested in previous PR)

These are about to be deprecated, please see the comment above. I'm not sure of the result of such change anyway, will this make the simulator crash?
I'm ok with it sending txs and being blocked applicatively rather than by its healthcheck.

---

crates/apollo_http_server/src/http_server_test.rs line 108 at r1 (raw file):

Previously, matanl-starkware (Matan Lior) wrote…

Please verify the return code is 503 (and not some other error that might have happened during add_tx)

Done

[matanl-starkware]

@matanl-starkware reviewed 5 files and all commit messages, and resolved 2 discussions.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware).

[graphite-app]

Merge activity

• Jan 8, 12:12 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.
• Jan 11, 10:14 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.