-
Notifications
You must be signed in to change notification settings - Fork 65
apollo_http_server: add dynamic config poller service #11534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apollo_http_server: add dynamic config poller service #11534
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
matanl-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful
@matanl-starkware reviewed 1 file and all commit messages, and made 2 comments.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware).
crates/apollo_http_server/src/http_server.rs line 31 at r1 (raw file):
use starknet_api::serde_utils::bytes_from_hex_str; use starknet_api::transaction::fields::ValidResourceBounds; use tokio::sync::watch::{channel, Receiver, Sender};
IMO, this leaves the usage too vague.
I'd prefer to see watch::Sender used in the code.
Code quote:
use tokio::sync::watch::{channel, Receiver, Sender};d3110ba to
5e4ca34
Compare
4cd4f39 to
ad4469b
Compare
5e4ca34 to
1db5b08
Compare
ad4469b to
0e82344
Compare
ad4469b to
cd54d4c
Compare
1db5b08 to
3e7fc5d
Compare
3e7fc5d to
2353f4d
Compare
Merge activity
|
2353f4d to
824f722
Compare
824f722 to
3207adb
Compare
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Itay-Tsabary-Starkware reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware).

No description provided.