Skip to content

Conversation

@Itay-Tsabary-Starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

Itay-Tsabary-Starkware commented Jan 8, 2026

Copy link
Collaborator

@matanl-starkware matanl-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Beautiful

@matanl-starkware reviewed 1 file and all commit messages, and made 2 comments.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware).


crates/apollo_http_server/src/http_server.rs line 31 at r1 (raw file):

use starknet_api::serde_utils::bytes_from_hex_str;
use starknet_api::transaction::fields::ValidResourceBounds;
use tokio::sync::watch::{channel, Receiver, Sender};

IMO, this leaves the usage too vague.
I'd prefer to see watch::Sender used in the code.

Code quote:

use tokio::sync::watch::{channel, Receiver, Sender};

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the 01-08-apollo_http_server_add_dynamic_config_poller_service branch from d3110ba to 5e4ca34 Compare January 11, 2026 07:30
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the 01-06-apollo_http_server_use_allow_new_tx_flag branch from 4cd4f39 to ad4469b Compare January 11, 2026 07:30
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the 01-08-apollo_http_server_add_dynamic_config_poller_service branch from 5e4ca34 to 1db5b08 Compare January 11, 2026 10:13
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the 01-06-apollo_http_server_use_allow_new_tx_flag branch from ad4469b to 0e82344 Compare January 11, 2026 10:13
@graphite-app graphite-app bot changed the base branch from 01-06-apollo_http_server_use_allow_new_tx_flag to graphite-base/11534 January 11, 2026 10:13
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the base branch from graphite-base/11534 to 01-06-apollo_http_server_use_allow_new_tx_flag January 11, 2026 10:13
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the 01-06-apollo_http_server_use_allow_new_tx_flag branch from ad4469b to cd54d4c Compare January 11, 2026 11:01
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the 01-08-apollo_http_server_add_dynamic_config_poller_service branch from 1db5b08 to 3e7fc5d Compare January 11, 2026 11:01
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the base branch from 01-06-apollo_http_server_use_allow_new_tx_flag to main-v0.14.1-committer January 11, 2026 11:48
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the 01-08-apollo_http_server_add_dynamic_config_poller_service branch from 3e7fc5d to 2353f4d Compare January 11, 2026 11:48
@graphite-app
Copy link

graphite-app bot commented Jan 11, 2026

Merge activity

  • Jan 11, 11:49 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the 01-08-apollo_http_server_add_dynamic_config_poller_service branch from 2353f4d to 824f722 Compare January 11, 2026 13:01
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the 01-08-apollo_http_server_add_dynamic_config_poller_service branch from 824f722 to 3207adb Compare January 11, 2026 13:42
Copy link
Collaborator Author

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Itay-Tsabary-Starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware).

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware added this pull request to the merge queue Jan 11, 2026
Merged via the queue into main-v0.14.1-committer with commit 1b3de82 Jan 11, 2026
15 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants