apollo_http_server: polling interval in config

[Itay-Tsabary-Starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[Itay-Tsabary-Starkware]

• apollo_http_server: polling interval in config #11537 👈 (View in Graphite)
• apollo_http_server: add dynamic config poller service #11534
• apollo_http_server: use allow new tx flag #11454
• apollo_deployments: add missing committer in batcher config #11573 : 4 other dependent PRs (#11354 , #11393 , #11570 and 1 other)
• main-v0.14.1-committer

This stack of pull requests is managed by Graphite. Learn more about stacking.

[matanl-starkware]

@matanl-starkware reviewed 5 files and all commit messages, and made 2 comments.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware).

---

crates/apollo_deployments/resources/app_configs/replacer_http_server_config.json line 4 at r1 (raw file):

  "http_server_config.dynamic_config.accept_new_txs": true,
  "http_server_config.dynamic_config.max_sierra_program_size": 4194304,
  "http_server_config.static_config.dynamic_config_poll_interval": 1000,

What about making it a dynamic config?

Code quote:

"http_server_config.static_config.dynamic_config_poll_interval"

---

crates/apollo_deployments/resources/app_configs/replacer_http_server_config.json line 4 at r1 (raw file):

  "http_server_config.dynamic_config.accept_new_txs": true,
  "http_server_config.dynamic_config.max_sierra_program_size": 4194304,
  "http_server_config.static_config.dynamic_config_poll_interval": 1000,

Suggestion:

dynamic_config_poll_interval_millis

[Itay-Tsabary-Starkware]

@Itay-Tsabary-Starkware made 2 comments.
Reviewable status: 4 of 5 files reviewed, all discussions resolved (waiting on @matanl-starkware).

---

crates/apollo_deployments/resources/app_configs/replacer_http_server_config.json line 4 at r1 (raw file):

Previously, matanl-starkware (Matan Lior) wrote…

What about making it a dynamic config?

It's a static config, affecting the parameters of the dynamic config (please see it is under static_config)

---

crates/apollo_deployments/resources/app_configs/replacer_http_server_config.json line 4 at r1 (raw file):

  "http_server_config.dynamic_config.accept_new_txs": true,
  "http_server_config.dynamic_config.max_sierra_program_size": 4194304,
  "http_server_config.static_config.dynamic_config_poll_interval": 1000,

It's a duration object, not a number, it doesn't have units
I agree it's serialization name is awkward, but better like this imo.

[Itay-Tsabary-Starkware]

@Itay-Tsabary-Starkware reviewed 5 files and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware).

[graphite-app]

Merge activity

• Jan 11, 2:11 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.